h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-16 17:03:18 +08:00
Code Issues Releases Wiki Activity

Refactor to avoid duplicate code

Browse Source
This commit is contained in:
Naxesss 2021-11-10 06:18:40 +01:00
parent b888185799
commit 72ee2b1556
1 changed files with 9 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
osu.Game.Tests/Editing/Checks/CheckBackgroundQualityTest.cs
View File

@ -54,7 +54,7 @@ namespace osu.Game.Tests.Editing.Checks
{ {
// While this is a problem, it is out of scope for this check and is caught by a different one. // While this is a problem, it is out of scope for this check and is caught by a different one.
beatmap.Metadata.BackgroundFile = string.Empty; beatmap.Metadata.BackgroundFile = string.Empty;
var context = getContext(null, System.Array.Empty<byte>()); var context = getContext(null, new MemoryStream(System.Array.Empty<byte>()));
Assert.That(check.Run(context), Is.Empty); Assert.That(check.Run(context), Is.Empty);
} }
@ -103,7 +103,7 @@ namespace osu.Game.Tests.Editing.Checks
[Test] [Test]
public void TestTooUncompressed() public void TestTooUncompressed()
{ {
var context = getContext(new Texture(1920, 1080), new byte[1024 * 1024 * 3]); var context = getContext(new Texture(1920, 1080), new MemoryStream(new byte[1024 * 1024 * 3]));
var issues = check.Run(context).ToList(); var issues = check.Run(context).ToList();
@ -117,31 +117,26 @@ namespace osu.Game.Tests.Editing.Checks
var background = new Texture(1920, 1080); var background = new Texture(1920, 1080);
var stream = new Mock<MemoryStream>(new byte[1024 * 1024]); var stream = new Mock<MemoryStream>(new byte[1024 * 1024]);
var mock = new Mock<IWorkingBeatmap>(); var context = getContext(background, stream.Object);
mock.SetupGet(w => w.Beatmap).Returns(beatmap);
mock.SetupGet(w => w.Background).Returns(background);
mock.Setup(w => w.GetStream(It.IsAny<string>())).Returns(stream.Object);
var context = new BeatmapVerifierContext(beatmap, mock.Object);
Assert.That(check.Run(context), Is.Empty); Assert.That(check.Run(context), Is.Empty);
stream.Verify(x => x.Close(), Times.Once()); stream.Verify(x => x.Close(), Times.Once());
} }
private BeatmapVerifierContext getContext(Texture background, [CanBeNull] byte[] fileBytes = null) private BeatmapVerifierContext getContext(Texture background, [CanBeNull] Stream stream = null)
{ {
return new BeatmapVerifierContext(beatmap, getMockWorkingBeatmap(background, fileBytes).Object); return new BeatmapVerifierContext(beatmap, getMockWorkingBeatmap(background, stream).Object);
} }
/// <summary> /// <summary>
/// Returns the mock of the working beatmap with the given background and filesize. /// Returns the mock of the working beatmap with the given background and its file stream.
/// </summary> /// </summary>
/// <param name="background">The texture of the background.</param> /// <param name="background">The texture of the background.</param>
/// <param name="fileBytes">The bytes that represent the background file.</param> /// <param name="stream">The stream representing the background file.</param>
private Mock<IWorkingBeatmap> getMockWorkingBeatmap(Texture background, [CanBeNull] byte[] fileBytes = null) private Mock<IWorkingBeatmap> getMockWorkingBeatmap(Texture background, [CanBeNull] Stream stream = null)
{ {
var stream = new MemoryStream(fileBytes ?? new byte[1024 * 1024]); stream ??= new MemoryStream(new byte[1024 * 1024]);
var mock = new Mock<IWorkingBeatmap>(); var mock = new Mock<IWorkingBeatmap>();
mock.SetupGet(w => w.Beatmap).Returns(beatmap); mock.SetupGet(w => w.Beatmap).Returns(beatmap);