From 72c5c9848f8761c719ca1fa22ecc6f784019d0ff Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Wed, 29 Mar 2023 14:44:42 +0900
Subject: [PATCH] Always use `LocalisableString` fallbacks when deploying debug
 and viewing english

This allows changes to `xxxStrings.cs` files to immediately reflect in
the UI, which is (at least for me) an expectation.
---
 osu.Game/Localisation/ResourceManagerLocalisationStore.cs | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/osu.Game/Localisation/ResourceManagerLocalisationStore.cs b/osu.Game/Localisation/ResourceManagerLocalisationStore.cs
index d2ff783413..50a450c101 100644
--- a/osu.Game/Localisation/ResourceManagerLocalisationStore.cs
+++ b/osu.Game/Localisation/ResourceManagerLocalisationStore.cs
@@ -11,6 +11,7 @@ using System.Linq;
 using System.Resources;
 using System.Threading;
 using System.Threading.Tasks;
+using osu.Framework.Development;
 using osu.Framework.Localisation;
 
 namespace osu.Game.Localisation
@@ -65,6 +66,11 @@ namespace osu.Game.Localisation
                 if (manager == null)
                     return null;
 
+                // When running a debug build and in viewing english culture, use the fallbacks rather than osu-resources baked strings.
+                // This is what a developer expects to see when making changes to `xxxStrings.cs` files.
+                if (DebugUtils.IsDebugBuild && EffectiveCulture.Name == @"en")
+                    return null;
+
                 try
                 {
                     return manager.GetString(key, EffectiveCulture);