h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-03-01 02:22:55 +08:00
Code Issues Releases Wiki Activity

Flip method parameters to make sense

Browse Source 
See 537f64c75e (r931785228)
This commit is contained in:
Salman Ahmed 2022-07-28 08:04:53 +03:00
parent 537f64c75e
commit 72961ec336
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
osu.Game.Rulesets.Osu/Mods/OsuModTarget.cs
View File

@ -167,6 +167,7 @@ namespace osu.Game.Rulesets.Osu.Mods
public override void ApplyToBeatmap(IBeatmap beatmap) public override void ApplyToBeatmap(IBeatmap beatmap)
{ {
Seed.Value ??= RNG.Next(); Seed.Value ??= RNG.Next();
var rng = new Random(Seed.Value.Value); var rng = new Random(Seed.Value.Value);
var osuBeatmap = (OsuBeatmap)beatmap; var osuBeatmap = (OsuBeatmap)beatmap;
@ -185,11 +186,11 @@ namespace osu.Game.Rulesets.Osu.Mods
return (OsuHitObject)newCircle; return (OsuHitObject)newCircle;
}).ToList(); }).ToList();
addHitSamples(originalHitObjects, hitObjects); addHitSamples(hitObjects, originalHitObjects);
fixComboInfo(originalHitObjects, hitObjects); fixComboInfo(hitObjects, originalHitObjects);
randomizeCirclePos(rng, hitObjects); randomizeCirclePos(hitObjects, rng);
osuBeatmap.HitObjects = hitObjects; osuBeatmap.HitObjects = hitObjects;
@ -224,7 +225,7 @@ namespace osu.Game.Rulesets.Osu.Mods
return beats; return beats;
} }
private void addHitSamples(List<OsuHitObject> originalHitObjects, IEnumerable<OsuHitObject> hitObjects) private void addHitSamples(IEnumerable<OsuHitObject> hitObjects, List<OsuHitObject> originalHitObjects)
{ {
foreach (var obj in hitObjects) foreach (var obj in hitObjects)
{ {
@ -236,7 +237,7 @@ namespace osu.Game.Rulesets.Osu.Mods
} }
} }
private void fixComboInfo(List<OsuHitObject> originalHitObjects, List<OsuHitObject> hitObjects) private void fixComboInfo(List<OsuHitObject> hitObjects, List<OsuHitObject> originalHitObjects)
{ {
// Copy combo indices from an original object at the same time or from the closest preceding object // Copy combo indices from an original object at the same time or from the closest preceding object
// (Objects lying between two combos are assumed to belong to the preceding combo) // (Objects lying between two combos are assumed to belong to the preceding combo)
@ -270,7 +271,7 @@ namespace osu.Game.Rulesets.Osu.Mods
} }
} }
private void randomizeCirclePos(Random rng, IReadOnlyList<OsuHitObject> hitObjects) private void randomizeCirclePos(IReadOnlyList<OsuHitObject> hitObjects, Random rng)
{ {
if (hitObjects.Count == 0) return; if (hitObjects.Count == 0) return;