h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-19 15:02:54 +08:00
Code Issues Releases Wiki Activity

Only convert non-legacy frames (and throw on conversion failure)

Browse Source
This commit is contained in:
Dean Herbert 2022-02-28 16:40:00 +09:00
parent 2e96f74c94
commit 723e96309a
1 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
osu.Game/Scoring/Legacy/LegacyScoreEncoder.cs
View File

@ -10,6 +10,7 @@ using osu.Framework.Extensions;
using osu.Game.Beatmaps; using osu.Game.Beatmaps;
using osu.Game.IO.Legacy; using osu.Game.IO.Legacy;
using osu.Game.Replays.Legacy; using osu.Game.Replays.Legacy;
using osu.Game.Rulesets.Replays;
using osu.Game.Rulesets.Replays.Types; using osu.Game.Rulesets.Replays.Types;
using SharpCompress.Compressors.LZMA; using SharpCompress.Compressors.LZMA;
@ -112,11 +113,16 @@ namespace osu.Game.Scoring.Legacy
{ {
int lastTime = 0; int lastTime = 0;
foreach (var f in score.Replay.Frames.OfType<IConvertibleReplayFrame>().Select(f => f.ToLegacy(beatmap))) foreach (var f in score.Replay.Frames)
{ {
var legacyFrame = getLegacyFrame(f);
if (legacyFrame == null)
throw new ArgumentException("One or more frames could not be converted to legacy frames");
// Rounding because stable could only parse integral values // Rounding because stable could only parse integral values
int time = (int)Math.Round(f.Time); int time = (int)Math.Round(legacyFrame.Time);
replayData.Append(FormattableString.Invariant($"{time - lastTime}|{f.MouseX ?? 0}|{f.MouseY ?? 0}|{(int)f.ButtonState},")); replayData.Append(FormattableString.Invariant($"{time - lastTime}|{legacyFrame.MouseX ?? 0}|{legacyFrame.MouseY ?? 0}|{(int)legacyFrame.ButtonState},"));
lastTime = time; lastTime = time;
} }
} }
@ -128,6 +134,14 @@ namespace osu.Game.Scoring.Legacy
} }
} }
private LegacyReplayFrame getLegacyFrame(ReplayFrame replayFrame)
{
if (replayFrame is LegacyReplayFrame legacyFrame)
return legacyFrame;
return (replayFrame as IConvertibleReplayFrame)?.ToLegacy(beatmap);
}
private string getHpGraphFormatted() private string getHpGraphFormatted()
{ {
// todo: implement, maybe? // todo: implement, maybe?