1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-11 09:27:29 +08:00

slight restructure + comments

This commit is contained in:
Sheppsu 2024-09-09 02:06:24 -04:00
parent f2c98dd064
commit 70a502771b
2 changed files with 7 additions and 5 deletions

View File

@ -35,21 +35,19 @@ namespace osu.Game.Rulesets.Osu.UI
protected new OsuRulesetConfigManager Config => (OsuRulesetConfigManager)base.Config;
[Resolved]
private MultiSpectatorScreen? multiSpectatorScreen { get; set; }
public DrawableOsuRuleset(Ruleset ruleset, IBeatmap beatmap, IReadOnlyList<Mod>? mods = null)
: base(ruleset, beatmap, mods)
{
}
[BackgroundDependencyLoader]
private void load(Player? player)
private void load(Player? player, MultiSpectatorScreen? multiSpectatorScreen)
{
if (player is ReplayPlayer || player is SpectatorPlayer)
{
PlayfieldAdjustmentContainer.Add(new ReplayAnalysisOverlay(player.Score.Replay));
// if in multiplayer spectator mode, place the settings elsewhere
if (multiSpectatorScreen == null)
player.AddSettings(new ReplayAnalysisSettings(Config));
else if (!multiSpectatorScreen.SettingsAdded)

View File

@ -59,8 +59,12 @@ namespace osu.Game.Rulesets.Osu.UI
}
/// <summary>
/// false for loading, true for loaded
/// Invalidated when containers are not loaded nor loading, false if loading, and true if loaded
/// </summary>
/// <remarks>
/// Knowing the loading/loaded state is for avoiding an enumeration error when adding
/// new entries and not starting a new load while loading
/// </remarks>
private readonly Cached<bool> loadState = new Cached<bool>();
private CancellationTokenSource? generationCancellationSource;