Add missing lock coverage when using subscriptionActions dictionary

2026-05-26 06:09:53 +08:00 · 2022-01-23 18:00:24 +09:00
parent 297ffec359
commit 70a120ea8a
1 changed files with 6 additions and 4 deletions
@@ -249,11 +249,13 @@ namespace osu.Game.Database

            return new InvokeOnDisposal(() =>
            {
-                // TODO: this likely needs to be run on the update thread.
-                if (subscriptionActions.TryGetValue(action, out var unsubscriptionAction))
+                lock (contextLock)
                {
-                    unsubscriptionAction?.Dispose();
-                    subscriptionActions.Remove(action);
+                    if (subscriptionActions.TryGetValue(action, out var unsubscriptionAction))
+                    {
+                        unsubscriptionAction?.Dispose();
+                        subscriptionActions.Remove(action);
+                    }
                }
            });
        }