From 6e76e5900a4d965eddecb7dc2223d47cf8d2c38b Mon Sep 17 00:00:00 2001
From: Salman Ahmed <email@iisalman.me>
Date: Wed, 29 Apr 2020 05:08:38 +0300
Subject: [PATCH] Rename is-in-any check method to a more legible name

---
 osu.Game.Tests/NonVisual/PeriodTrackerTest.cs | 22 +++++++++----------
 osu.Game/Screens/Play/BreakTracker.cs         |  2 +-
 osu.Game/Utils/PeriodTracker.cs               |  2 +-
 3 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/osu.Game.Tests/NonVisual/PeriodTrackerTest.cs b/osu.Game.Tests/NonVisual/PeriodTrackerTest.cs
index 39eea2b386..f033672576 100644
--- a/osu.Game.Tests/NonVisual/PeriodTrackerTest.cs
+++ b/osu.Game.Tests/NonVisual/PeriodTrackerTest.cs
@@ -29,9 +29,9 @@ namespace osu.Game.Tests.NonVisual
             var tracker = new PeriodTracker { Periods = test_single_period };
 
             var period = test_single_period.Single();
-            Assert.IsTrue(tracker.Contains(period.Start));
-            Assert.IsTrue(tracker.Contains(getMidTime(period)));
-            Assert.IsTrue(tracker.Contains(period.End));
+            Assert.IsTrue(tracker.IsInAny(period.Start));
+            Assert.IsTrue(tracker.IsInAny(getMidTime(period)));
+            Assert.IsTrue(tracker.IsInAny(period.End));
         }
 
         [Test]
@@ -40,7 +40,7 @@ namespace osu.Game.Tests.NonVisual
             var tracker = new PeriodTracker { Periods = test_periods };
 
             foreach (var period in test_periods)
-                Assert.IsTrue(tracker.Contains(getMidTime(period)));
+                Assert.IsTrue(tracker.IsInAny(getMidTime(period)));
         }
 
         [Test]
@@ -49,7 +49,7 @@ namespace osu.Game.Tests.NonVisual
             var tracker = new PeriodTracker { Periods = test_periods };
 
             foreach (var period in test_periods.OrderBy(_ => RNG.Next()))
-                Assert.IsTrue(tracker.Contains(getMidTime(period)));
+                Assert.IsTrue(tracker.IsInAny(getMidTime(period)));
         }
 
         [Test]
@@ -64,12 +64,12 @@ namespace osu.Game.Tests.NonVisual
                 }
             };
 
-            Assert.IsFalse(tracker.Contains(0.9), "Time before first period is being considered inside");
+            Assert.IsFalse(tracker.IsInAny(0.9), "Time before first period is being considered inside");
 
-            Assert.IsFalse(tracker.Contains(2.1), "Time right after first period is being considered inside");
-            Assert.IsFalse(tracker.Contains(2.9), "Time right before second period is being considered inside");
+            Assert.IsFalse(tracker.IsInAny(2.1), "Time right after first period is being considered inside");
+            Assert.IsFalse(tracker.IsInAny(2.9), "Time right before second period is being considered inside");
 
-            Assert.IsFalse(tracker.Contains(4.1), "Time after last period is being considered inside");
+            Assert.IsFalse(tracker.IsInAny(4.1), "Time after last period is being considered inside");
         }
 
         [Test]
@@ -78,10 +78,10 @@ namespace osu.Game.Tests.NonVisual
             var tracker = new PeriodTracker { Periods = test_single_period };
 
             var period = test_single_period.Single();
-            Assert.IsTrue(tracker.Contains(getMidTime(period)));
+            Assert.IsTrue(tracker.IsInAny(getMidTime(period)));
 
             tracker.Periods = null;
-            Assert.IsFalse(tracker.Contains(getMidTime(period)));
+            Assert.IsFalse(tracker.IsInAny(getMidTime(period)));
         }
 
         [Test]
diff --git a/osu.Game/Screens/Play/BreakTracker.cs b/osu.Game/Screens/Play/BreakTracker.cs
index e30c0c6dec..eb77cb9369 100644
--- a/osu.Game/Screens/Play/BreakTracker.cs
+++ b/osu.Game/Screens/Play/BreakTracker.cs
@@ -48,7 +48,7 @@ namespace osu.Game.Screens.Play
 
             var time = Clock.CurrentTime;
 
-            isBreakTime.Value = tracker.Contains(time)
+            isBreakTime.Value = tracker.IsInAny(time)
                                 || time < gameplayStartTime
                                 || scoreProcessor?.HasCompleted == true;
         }
diff --git a/osu.Game/Utils/PeriodTracker.cs b/osu.Game/Utils/PeriodTracker.cs
index 589f061c1d..49b372bb27 100644
--- a/osu.Game/Utils/PeriodTracker.cs
+++ b/osu.Game/Utils/PeriodTracker.cs
@@ -43,7 +43,7 @@ namespace osu.Game.Utils
         /// Whether the provided time is in any of the added periods.
         /// </summary>
         /// <param name="time">The time value to check for.</param>
-        public bool Contains(double time)
+        public bool IsInAny(double time)
         {
             if (periods.Count == 0)
                 return false;