h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-16 17:42:54 +08:00
Code Issues Releases Wiki Activity

Include misses in the great window deviation calc

Browse Source
This commit is contained in:
nathen 2024-03-10 00:19:04 -05:00
parent caba0510db
commit 6ddb2b7f8b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game.Rulesets.Taiko/Difficulty/TaikoPerformanceCalculator.cs
View File

@ -129,12 +129,12 @@ namespace osu.Game.Rulesets.Taiko.Difficulty
const double z = 2.32634787404; // 99% critical value for the normal distribution (one-tailed). const double z = 2.32634787404; // 99% critical value for the normal distribution (one-tailed).
// The upper bound on deviation, calculated with the ratio of 300s to 100s, and the great hit window. // The upper bound on deviation, calculated with the ratio of 300s to objects, and the great hit window.
double? calcDeviationGreatWindow() double? calcDeviationGreatWindow()
{ {
if (countGreat == 0) return null; if (countGreat == 0) return null;
double n = totalSuccessfulHits; double n = totalHits;
// Proportion of greats hit, ignoring misses. // Proportion of greats hit, ignoring misses.
double p = countGreat / n; double p = countGreat / n;
@ -146,7 +146,7 @@ namespace osu.Game.Rulesets.Taiko.Difficulty
return h300 / (Math.Sqrt(2) * SpecialFunctions.ErfInv(pLowerBound)); return h300 / (Math.Sqrt(2) * SpecialFunctions.ErfInv(pLowerBound));
} }
// The upper bound on deviation, calculated with the ratio of 300s + 100s to misses, and the good hit window. // The upper bound on deviation, calculated with the ratio of 300s + 100s to objects, and the good hit window.
// This will return a lower value than the first method when the number of 100s is high, but the miss count is low. // This will return a lower value than the first method when the number of 100s is high, but the miss count is low.
double? calcDeviationGoodWindow() double? calcDeviationGoodWindow()
{ {