From 6d00aff9fd7958227a16e607b32121130b9d3e70 Mon Sep 17 00:00:00 2001
From: Kyle Chang <kyle.r.chang@gmail.com>
Date: Tue, 30 Oct 2018 00:13:33 -0400
Subject: [PATCH] Add type parameter to IApplicableToBeatmap

---
 osu.Game.Rulesets.Mania/Mods/ManiaModDualStages.cs |  7 ++++---
 osu.Game/Rulesets/Mods/IApplicableToBeatmap.cs     | 13 ++++++++-----
 osu.Game/Rulesets/UI/RulesetContainer.cs           |  2 +-
 3 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/osu.Game.Rulesets.Mania/Mods/ManiaModDualStages.cs b/osu.Game.Rulesets.Mania/Mods/ManiaModDualStages.cs
index 12b62d2b65..4790a77cc0 100644
--- a/osu.Game.Rulesets.Mania/Mods/ManiaModDualStages.cs
+++ b/osu.Game.Rulesets.Mania/Mods/ManiaModDualStages.cs
@@ -4,11 +4,12 @@
 using System.Collections.Generic;
 using osu.Game.Beatmaps;
 using osu.Game.Rulesets.Mania.Beatmaps;
+using osu.Game.Rulesets.Mania.Objects;
 using osu.Game.Rulesets.Mods;
 
 namespace osu.Game.Rulesets.Mania.Mods
 {
-    public class ManiaModDualStages : Mod, IPlayfieldTypeMod, IApplicableToBeatmapConverter, IApplicableToBeatmap
+    public class ManiaModDualStages : Mod, IPlayfieldTypeMod, IApplicableToBeatmapConverter, IApplicableToBeatmap<ManiaHitObject>
     {
         public override string Name => "Dual Stages";
         public override string ShortenedName => "DS";
@@ -31,12 +32,12 @@ namespace osu.Game.Rulesets.Mania.Mods
             mbc.TargetColumns *= 2;
         }
 
-        public void ApplyToBeatmap(IBeatmap beatmap)
+        public void ApplyToBeatmap(Beatmap<ManiaHitObject> beatmap)
         {
             if (isForCurrentRuleset)
                 return;
 
-            var maniaBeatmap = (ManiaBeatmap) beatmap;
+            var maniaBeatmap = (ManiaBeatmap)beatmap;
 
             var newDefinitions = new List<StageDefinition>();
             foreach (var existing in maniaBeatmap.Stages)
diff --git a/osu.Game/Rulesets/Mods/IApplicableToBeatmap.cs b/osu.Game/Rulesets/Mods/IApplicableToBeatmap.cs
index e1398ecf2b..1eb74ca76a 100644
--- a/osu.Game/Rulesets/Mods/IApplicableToBeatmap.cs
+++ b/osu.Game/Rulesets/Mods/IApplicableToBeatmap.cs
@@ -2,18 +2,21 @@
 // Licensed under the MIT Licence - https://raw.githubusercontent.com/ppy/osu/master/LICENCE
 
 using osu.Game.Beatmaps;
+using osu.Game.Rulesets.Objects;
 
 namespace osu.Game.Rulesets.Mods
 {
     /// <summary>
-    /// Interface for a <see cref="Mod"/> that applies changes to a <see cref="Beatmap"/>.
+    /// Interface for a <see cref="Mod"/> that applies changes to a <see cref="Beatmap"/>
+    /// after conversion and post-processing has completed.
     /// </summary>
-    public interface IApplicableToBeatmap : IApplicableMod
+    public interface IApplicableToBeatmap<TObject> : IApplicableMod
+        where TObject : HitObject
     {
         /// <summary>
-        /// Applies this <see cref="Mod"/> to a <see cref="Beatmap"/>.
+        /// Applies this <see cref="IApplicableToBeatmap{TObject}"/> to a <see cref="Beatmap{TObject}"/>.
         /// </summary>
-        /// <param name="beatmap">The <see cref="Beatmap"/> to apply to.</param>
-        void ApplyToBeatmap(IBeatmap beatmap);
+        /// <param name="beatmap">The <see cref="Beatmap{TObject}"/> to apply to.</param>
+        void ApplyToBeatmap(Beatmap<TObject> beatmap);
     }
 }
diff --git a/osu.Game/Rulesets/UI/RulesetContainer.cs b/osu.Game/Rulesets/UI/RulesetContainer.cs
index 4b55bb558d..d1303e21a9 100644
--- a/osu.Game/Rulesets/UI/RulesetContainer.cs
+++ b/osu.Game/Rulesets/UI/RulesetContainer.cs
@@ -271,7 +271,7 @@ namespace osu.Game.Rulesets.UI
             if (mods == null)
                 return;
 
-            foreach (var mod in mods.OfType<IApplicableToBeatmap>())
+            foreach (var mod in mods.OfType<IApplicableToBeatmap<TObject>>())
                 mod.ApplyToBeatmap(Beatmap);
         }