From 6c60db550ff9c3e76abdc89add98d6f26e415b28 Mon Sep 17 00:00:00 2001
From: Andrei Zavatski <megaman9919@gmail.com>
Date: Sun, 18 Aug 2019 16:24:13 +0300
Subject: [PATCH] Fix crash if ruleset has no Meh hit windows

---
 osu.Game/Screens/Play/HUD/HitErrorDisplay.cs | 21 ++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/osu.Game/Screens/Play/HUD/HitErrorDisplay.cs b/osu.Game/Screens/Play/HUD/HitErrorDisplay.cs
index 2959a9aca7..2ed06209de 100644
--- a/osu.Game/Screens/Play/HUD/HitErrorDisplay.cs
+++ b/osu.Game/Screens/Play/HUD/HitErrorDisplay.cs
@@ -107,37 +107,46 @@ namespace osu.Game.Screens.Play.HUD
                 {
                     RelativeSizeAxes = Axes.Both,
                     Colour = ColourInfo.GradientVertical(colours.Yellow.Opacity(0), colours.Yellow),
-                    Height = (float)((HitWindows.Meh - HitWindows.Good) / (HitWindows.Meh * 2))
+                    Height = (float)((getMehHitWindows() - HitWindows.Good) / (getMehHitWindows() * 2))
                 },
                 new Box
                 {
                     RelativeSizeAxes = Axes.Both,
                     Colour = colours.Green,
-                    Height = (float)((HitWindows.Good - HitWindows.Great) / (HitWindows.Meh * 2))
+                    Height = (float)((HitWindows.Good - HitWindows.Great) / (getMehHitWindows() * 2))
                 },
                 new Box
                 {
                     RelativeSizeAxes = Axes.Both,
                     Colour = colours.BlueLight,
-                    Height = (float)(HitWindows.Great / HitWindows.Meh)
+                    Height = (float)(HitWindows.Great / getMehHitWindows())
                 },
                 new Box
                 {
                     RelativeSizeAxes = Axes.Both,
                     Colour = colours.Green,
-                    Height = (float)((HitWindows.Good - HitWindows.Great) / (HitWindows.Meh * 2))
+                    Height = (float)((HitWindows.Good - HitWindows.Great) / (getMehHitWindows() * 2))
                 },
                 new Box
                 {
                     RelativeSizeAxes = Axes.Both,
                     Colour = ColourInfo.GradientVertical(colours.Yellow, colours.Yellow.Opacity(0)),
-                    Height = (float)((HitWindows.Meh - HitWindows.Good) / (HitWindows.Meh * 2))
+                    Height = (float)((getMehHitWindows() - HitWindows.Good) / (getMehHitWindows() * 2))
                 }
             });
 
             type.BindValueChanged(onTypeChanged, true);
         }
 
+        private double getMehHitWindows()
+        {
+            // In case if ruleset has no Meh hit windows (like Taiko)
+            if (HitWindows.Meh == 0)
+                return HitWindows.Good + 40;
+
+            return HitWindows.Meh;
+        }
+
         private void onTypeChanged(ValueChangedEvent<ScoreMeterType> type)
         {
             switch (type.NewValue)
@@ -183,7 +192,7 @@ namespace osu.Game.Screens.Play.HUD
             }
         };
 
-        private float getRelativeJudgementPosition(double value) => (float)(value / HitWindows.Meh);
+        private float getRelativeJudgementPosition(double value) => (float)(value / getMehHitWindows());
 
         private float calculateArrowPosition(JudgementResult newJudgement)
         {