From 6c60a096314280375785ba0672e07d1287a3861b Mon Sep 17 00:00:00 2001 From: Arthur Araujo Date: Fri, 29 Mar 2024 07:38:26 -0300 Subject: [PATCH] Change dim resseting to be at `playExitingTransition()` --- osu.Game/Screens/Play/PlayerLoader.cs | 6 +----- osu.Game/Screens/Select/SongSelect.cs | 3 +++ 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/osu.Game/Screens/Play/PlayerLoader.cs b/osu.Game/Screens/Play/PlayerLoader.cs index 9b936c02be..4f7e21dddf 100644 --- a/osu.Game/Screens/Play/PlayerLoader.cs +++ b/osu.Game/Screens/Play/PlayerLoader.cs @@ -98,11 +98,7 @@ namespace osu.Game.Screens.Play backgroundBrightnessReduction = value; - ApplyToBackground(b => - { - b.DimWhenUserSettingsIgnored.Value = 0; - b.FadeColour(OsuColour.Gray(backgroundBrightnessReduction ? 0.8f : 1), 200); - }); + ApplyToBackground(b => b.FadeColour(OsuColour.Gray(backgroundBrightnessReduction ? 0.8f : 1), 200)); } } diff --git a/osu.Game/Screens/Select/SongSelect.cs b/osu.Game/Screens/Select/SongSelect.cs index 15469fad5b..a87745912c 100644 --- a/osu.Game/Screens/Select/SongSelect.cs +++ b/osu.Game/Screens/Select/SongSelect.cs @@ -754,6 +754,9 @@ namespace osu.Game.Screens.Select endLooping(); + // Reset any dim SongSelect previously applied to the background + ApplyToBackground(b => b.DimWhenUserSettingsIgnored.Value = 0); + FilterControl.MoveToY(-120, 500, Easing.OutQuint); FilterControl.FadeOut(200, Easing.OutQuint);