h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-13 05:22:54 +08:00
Code Issues Releases Wiki Activity

Added check for infinite subpoints for PerfectCurve

Browse Source
This commit is contained in:
Aurelian 2024-05-27 20:32:18 +02:00
parent 172cfdf88d
commit 6c4def1c09
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
osu.Game/Rulesets/Objects/SliderPath.cs
View File

@ -330,11 +330,18 @@ namespace osu.Game.Rulesets.Objects
if (subControlPoints.Length != 3) if (subControlPoints.Length != 3)
break; break;
//If a curve's theta range almost equals zero, the radius needed to have more than a CircularArcProperties circularArcProperties = new CircularArcProperties(subControlPoints);
//floating point error difference is very large and results in a nearly straight path.
//Calculate it via a bezier aproximation instead. //if false, we'll end up breaking anyways when calculating subPath
//0.0005 corresponds with a radius of 8000 to have a more than 0.001 shift in the X value if (!circularArcProperties.IsValid)
if (Math.Abs(new CircularArcProperties(subControlPoints).ThetaRange) <= 0.0005d) break;
//Coppied from PathApproximator.CircularArcToPiecewiseLinear
int subPoints = (2f * circularArcProperties.Radius <= 0.1f) ? 2 : Math.Max(2, (int)Math.Ceiling(circularArcProperties.ThetaRange / (2.0 * Math.Acos(1f - (0.1f / circularArcProperties.Radius)))));
//if the amount of subpoints is int.MaxValue, causes an out of memory issue, so we default to bezier
//this only occurs for very large radii, so the result should be essentially a straight line anyways
if (subPoints == int.MaxValue)
break; break;
List<Vector2> subPath = PathApproximator.CircularArcToPiecewiseLinear(subControlPoints); List<Vector2> subPath = PathApproximator.CircularArcToPiecewiseLinear(subControlPoints);