h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-19 12:03:21 +08:00
Code Issues Releases Wiki Activity

Tidy up update state code, naming, xmldoc

Browse Source
This commit is contained in:
Dean Herbert 2020-12-29 14:25:08 +09:00
parent f7407347f7
commit 6aeb7ece66
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
osu.Game/Online/Multiplayer/StatefulMultiplayerClient.cs
View File

@ -303,7 +303,7 @@ namespace osu.Game.Online.Multiplayer
Room.Users.Single(u => u.UserID == userId).State = state; Room.Users.Single(u => u.UserID == userId).State = state;
updatePlayingUsers(userId, state); updateUserPlayingState(userId, state);
RoomUpdated?.Invoke(); RoomUpdated?.Invoke();
}, false); }, false);
@ -453,15 +453,22 @@ namespace osu.Game.Online.Multiplayer
apiRoom.Playlist.Add(playlistItem); apiRoom.Playlist.Add(playlistItem);
} }
private void updatePlayingUsers(int userId, MultiplayerUserState state) /// <summary>
/// For the provided user ID, update whether the user is included in <see cref="PlayingUsers"/>.
/// </summary>
/// <param name="userId">The user's ID.</param>
/// <param name="state">The new state of the user.</param>
private void updateUserPlayingState(int userId, MultiplayerUserState state)
{ {
bool isPlaying = state >= MultiplayerUserState.WaitingForLoad && state <= MultiplayerUserState.FinishedPlay;
bool wasPlaying = PlayingUsers.Contains(userId); bool wasPlaying = PlayingUsers.Contains(userId);
bool isPlaying = state >= MultiplayerUserState.WaitingForLoad && state <= MultiplayerUserState.FinishedPlay;
if (!wasPlaying && isPlaying) if (isPlaying == wasPlaying)
return;
if (isPlaying)
PlayingUsers.Add(userId); PlayingUsers.Add(userId);
else
if (wasPlaying && !isPlaying)
PlayingUsers.Remove(userId); PlayingUsers.Remove(userId);
} }
} }