From 6a1620031443f37c80db33b033a1199637bcc7cb Mon Sep 17 00:00:00 2001 From: clayton Date: Sat, 16 Aug 2025 04:55:49 -0700 Subject: [PATCH] Dedupe switch returns --- .../Skinning/Legacy/OsuLegacySkinTransformer.cs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/osu.Game.Rulesets.Osu/Skinning/Legacy/OsuLegacySkinTransformer.cs b/osu.Game.Rulesets.Osu/Skinning/Legacy/OsuLegacySkinTransformer.cs index 69e9cd00d5..7118b6f95e 100644 --- a/osu.Game.Rulesets.Osu/Skinning/Legacy/OsuLegacySkinTransformer.cs +++ b/osu.Game.Rulesets.Osu/Skinning/Legacy/OsuLegacySkinTransformer.cs @@ -125,7 +125,7 @@ namespace osu.Game.Rulesets.Osu.Skinning.Legacy if (getSliderPointTexture(resultComponent.Component) is Texture texture) return new LegacyJudgementPieceSliderTickHit { Texture = texture }; - return base.GetDrawableComponent(lookup); + break; // If the corresponding hit result displays a judgement and the miss texture isn't provided by this skin, don't look up the miss texture from any further skins. case HitResult.LargeTickMiss: @@ -135,12 +135,11 @@ namespace osu.Game.Rulesets.Osu.Skinning.Legacy : HitResult.SliderTailHit) != null) return base.GetDrawableComponent(lookup) ?? Drawable.Empty(); - return base.GetDrawableComponent(lookup); - - default: - return base.GetDrawableComponent(lookup); + break; } + return base.GetDrawableComponent(lookup); + Texture? getSliderPointTexture(HitResult result) { // https://github.com/peppy/osu-stable-reference/blob/0e91e49bc83fe8b21c3ba5f1eb2d5d06456eae84/osu!/GameModes/Play/Rulesets/Ruleset.cs#L799