From 68f4fa5a5781d1f6d2344cf6041d39c51ef9bf05 Mon Sep 17 00:00:00 2001
From: Huo Yaoyuan <huoyaoyuan@hotmail.com>
Date: Tue, 3 Dec 2024 00:00:31 +0800
Subject: [PATCH] Turn off CA1507

---
 .globalconfig                                                 | 4 ++++
 osu.Game/Online/API/Requests/Responses/APIKudosuHistory.cs    | 2 --
 .../Online/API/Requests/Responses/APIUserMostPlayedBeatmap.cs | 2 --
 .../Notifications/WebSocket/Events/NewChatMessageData.cs      | 2 --
 4 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/.globalconfig b/.globalconfig
index e2cd1926f0..ca7b86c778 100644
--- a/.globalconfig
+++ b/.globalconfig
@@ -50,6 +50,10 @@ dotnet_diagnostic.IDE1006.severity = warning
 # Too many noisy warnings for parsing/formatting numbers
 dotnet_diagnostic.CA1305.severity = none
 
+# CA1507: Use nameof to express symbol names
+# Flaggs serialization name attributes
+dotnet_diagnostic.CA1507.severity = suggestion
+
 # CA1806: Do not ignore method results
 # The usages for numeric parsing are explicitly optional
 dotnet_diagnostic.CA1806.severity = suggestion
diff --git a/osu.Game/Online/API/Requests/Responses/APIKudosuHistory.cs b/osu.Game/Online/API/Requests/Responses/APIKudosuHistory.cs
index 8e4cc387ed..583def8eda 100644
--- a/osu.Game/Online/API/Requests/Responses/APIKudosuHistory.cs
+++ b/osu.Game/Online/API/Requests/Responses/APIKudosuHistory.cs
@@ -45,9 +45,7 @@ namespace osu.Game.Online.API.Requests.Responses
 
         public KudosuAction Action;
 
-#pragma warning disable CA1507 // Happens to name the same because of casing preference
         [JsonProperty("action")]
-#pragma warning restore CA1507
         private string action
         {
             set
diff --git a/osu.Game/Online/API/Requests/Responses/APIUserMostPlayedBeatmap.cs b/osu.Game/Online/API/Requests/Responses/APIUserMostPlayedBeatmap.cs
index 38ad2bd02d..6d5fd59f9c 100644
--- a/osu.Game/Online/API/Requests/Responses/APIUserMostPlayedBeatmap.cs
+++ b/osu.Game/Online/API/Requests/Responses/APIUserMostPlayedBeatmap.cs
@@ -15,9 +15,7 @@ namespace osu.Game.Online.API.Requests.Responses
         [JsonProperty("count")]
         public int PlayCount { get; set; }
 
-#pragma warning disable CA1507 // Happens to name the same because of casing preference
         [JsonProperty("beatmap")]
-#pragma warning restore CA1507
         private APIBeatmap beatmap { get; set; }
 
         public APIBeatmap BeatmapInfo
diff --git a/osu.Game/Online/Notifications/WebSocket/Events/NewChatMessageData.cs b/osu.Game/Online/Notifications/WebSocket/Events/NewChatMessageData.cs
index 677286bb8a..ff9f5ee9f7 100644
--- a/osu.Game/Online/Notifications/WebSocket/Events/NewChatMessageData.cs
+++ b/osu.Game/Online/Notifications/WebSocket/Events/NewChatMessageData.cs
@@ -19,9 +19,7 @@ namespace osu.Game.Online.Notifications.WebSocket.Events
         [JsonProperty(@"messages")]
         public List<Message> Messages { get; set; } = null!;
 
-#pragma warning disable CA1507 // Happens to name the same because of casing preference
         [JsonProperty(@"users")]
-#pragma warning restore CA1507
         private List<APIUser> users { get; set; } = null!;
 
         [OnDeserialized]