1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-11 09:27:29 +08:00

Remove all usage of AuthorString

This commit is contained in:
Dean Herbert 2022-01-18 23:30:40 +09:00
parent 3596c6ed5d
commit 67bf95bc91
15 changed files with 15 additions and 27 deletions

View File

@ -40,7 +40,7 @@ namespace osu.Game.Rulesets.Catch.Tests
{ {
Artist = @"Unknown", Artist = @"Unknown",
Title = @"You're breathtaking", Title = @"You're breathtaking",
AuthorString = @"Everyone", Author = { Username = @"Everyone" },
}, },
Ruleset = new CatchRuleset().RulesetInfo Ruleset = new CatchRuleset().RulesetInfo
}, },

View File

@ -37,7 +37,7 @@ namespace osu.Game.Rulesets.Taiko.Tests
{ {
Artist = @"Unknown", Artist = @"Unknown",
Title = @"Sample Beatmap", Title = @"Sample Beatmap",
AuthorString = @"peppy", Author = { Username = @"peppy" },
}, },
Ruleset = new TaikoRuleset().RulesetInfo Ruleset = new TaikoRuleset().RulesetInfo
}, },

View File

@ -163,7 +163,7 @@ namespace osu.Game.Rulesets.Taiko.Tests.Skinning
{ {
Artist = "Unknown", Artist = "Unknown",
Title = "Sample Beatmap", Title = "Sample Beatmap",
AuthorString = "Craftplacer", Author = { Username = "Craftplacer" },
}, },
Ruleset = new TaikoRuleset().RulesetInfo Ruleset = new TaikoRuleset().RulesetInfo
}, },

View File

@ -30,7 +30,7 @@ namespace osu.Game.Tests.NonVisual.Filtering
ArtistUnicode = "check unicode too", ArtistUnicode = "check unicode too",
Title = "Title goes here", Title = "Title goes here",
TitleUnicode = "Title goes here", TitleUnicode = "Title goes here",
AuthorString = "The Author", Author = { Username = "The Author" },
Source = "unit tests", Source = "unit tests",
Tags = "look for tags too", Tags = "look for tags too",
}, },

View File

@ -89,7 +89,7 @@ namespace osu.Game.Tests.Resources
// Create random metadata, then we can check if sorting works based on these // Create random metadata, then we can check if sorting works based on these
Artist = "Some Artist " + RNG.Next(0, 9), Artist = "Some Artist " + RNG.Next(0, 9),
Title = $"Some Song (set id {setId}) {Guid.NewGuid()}", Title = $"Some Song (set id {setId}) {Guid.NewGuid()}",
AuthorString = "Some Guy " + RNG.Next(0, 9), Author = { Username = "Some Guy " + RNG.Next(0, 9) },
}; };
var beatmapSet = new BeatmapSetInfo var beatmapSet = new BeatmapSetInfo

View File

@ -52,7 +52,7 @@ namespace osu.Game.Tests.Visual.Multiplayer
{ {
Artist = "Some Artist", Artist = "Some Artist",
Title = "Some Beatmap", Title = "Some Beatmap",
AuthorString = "Some Author" Author = { Username = "Some Author" },
}; };
var beatmapSetInfo = new BeatmapSetInfo var beatmapSetInfo = new BeatmapSetInfo

View File

@ -100,7 +100,7 @@ namespace osu.Game.Tests.Visual.Navigation
var metadata = new BeatmapMetadata var metadata = new BeatmapMetadata
{ {
Artist = "SomeArtist", Artist = "SomeArtist",
AuthorString = "SomeAuthor", Author = { Username = "SomeAuthor" },
Title = $"import {i}" Title = $"import {i}"
}; };

View File

@ -41,7 +41,7 @@ namespace osu.Game.Tests.Visual.Navigation
Metadata = new BeatmapMetadata Metadata = new BeatmapMetadata
{ {
Artist = "SomeArtist", Artist = "SomeArtist",
AuthorString = "SomeAuthor", Author = { Username = "SomeAuthor" },
Title = "import" Title = "import"
}, },
BaseDifficulty = new BeatmapDifficulty(), BaseDifficulty = new BeatmapDifficulty(),
@ -53,7 +53,7 @@ namespace osu.Game.Tests.Visual.Navigation
Metadata = new BeatmapMetadata Metadata = new BeatmapMetadata
{ {
Artist = "SomeArtist", Artist = "SomeArtist",
AuthorString = "SomeAuthor", Author = { Username = "SomeAuthor" },
Title = "import" Title = "import"
}, },
BaseDifficulty = new BeatmapDifficulty(), BaseDifficulty = new BeatmapDifficulty(),

View File

@ -409,7 +409,7 @@ namespace osu.Game.Tests.Visual.SongSelect
set.Beatmaps.ForEach(b => b.Metadata.Artist = zzz_string); set.Beatmaps.ForEach(b => b.Metadata.Artist = zzz_string);
if (i == 16) if (i == 16)
set.Beatmaps.ForEach(b => b.Metadata.AuthorString = zzz_string); set.Beatmaps.ForEach(b => b.Metadata.Author.Username = zzz_string);
sets.Add(set); sets.Add(set);
} }

View File

@ -208,7 +208,7 @@ namespace osu.Game.Tests.Visual.SongSelect
{ {
Metadata = new BeatmapMetadata Metadata = new BeatmapMetadata
{ {
AuthorString = $"{ruleset.ShortName}Author", Author = { Username = $"{ruleset.ShortName}Author" },
Artist = $"{ruleset.ShortName}Artist", Artist = $"{ruleset.ShortName}Artist",
Source = $"{ruleset.ShortName}Source", Source = $"{ruleset.ShortName}Source",
Title = $"{ruleset.ShortName}Title" Title = $"{ruleset.ShortName}Title"
@ -230,7 +230,7 @@ namespace osu.Game.Tests.Visual.SongSelect
{ {
Metadata = new BeatmapMetadata Metadata = new BeatmapMetadata
{ {
AuthorString = "WWWWWWWWWWWWWWW", Author = { Username = "WWWWWWWWWWWWWWW" },
Artist = "Verrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrry long Artist", Artist = "Verrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrry long Artist",
Source = "Verrrrry long Source", Source = "Verrrrry long Source",
Title = "Verrrrry long Title" Title = "Verrrrry long Title"

View File

@ -54,7 +54,7 @@ namespace osu.Game.Beatmaps
{ {
Artist = @"Unknown", Artist = @"Unknown",
Title = @"Unknown", Title = @"Unknown",
AuthorString = @"Unknown Creator", Author = { Username = @"Unknown Creator" },
}, },
DifficultyName = @"Normal", DifficultyName = @"Normal",
BaseDifficulty = Difficulty, BaseDifficulty = Difficulty,

View File

@ -45,17 +45,6 @@ namespace osu.Game.Beatmaps
IUser IBeatmapMetadataInfo.Author => Author; IUser IBeatmapMetadataInfo.Author => Author;
#region Compatibility properties
[Ignored]
public string AuthorString
{
get => Author.Username;
set => Author.Username = value;
}
#endregion
public override string ToString() => this.GetDisplayTitle(); public override string ToString() => this.GetDisplayTitle();
} }
} }

View File

@ -251,7 +251,7 @@ namespace osu.Game.Beatmaps.Formats
break; break;
case @"Creator": case @"Creator":
metadata.AuthorString = pair.Value; metadata.Author.Username = pair.Value;
break; break;
case @"Version": case @"Version":

View File

@ -144,7 +144,6 @@ namespace osu.Game.Database
PreviewTime = metadata.PreviewTime, PreviewTime = metadata.PreviewTime,
AudioFile = metadata.AudioFile, AudioFile = metadata.AudioFile,
BackgroundFile = metadata.BackgroundFile, BackgroundFile = metadata.BackgroundFile,
AuthorString = metadata.AuthorString,
}; };
} }

View File

@ -110,7 +110,7 @@ namespace osu.Game.Screens.Edit.Setup
Beatmap.Metadata.TitleUnicode = TitleTextBox.Current.Value; Beatmap.Metadata.TitleUnicode = TitleTextBox.Current.Value;
Beatmap.Metadata.Title = RomanisedTitleTextBox.Current.Value; Beatmap.Metadata.Title = RomanisedTitleTextBox.Current.Value;
Beatmap.Metadata.AuthorString = creatorTextBox.Current.Value; Beatmap.Metadata.Author.Username = creatorTextBox.Current.Value;
Beatmap.BeatmapInfo.DifficultyName = difficultyTextBox.Current.Value; Beatmap.BeatmapInfo.DifficultyName = difficultyTextBox.Current.Value;
Beatmap.Metadata.Source = sourceTextBox.Current.Value; Beatmap.Metadata.Source = sourceTextBox.Current.Value;
Beatmap.Metadata.Tags = tagsTextBox.Current.Value; Beatmap.Metadata.Tags = tagsTextBox.Current.Value;