From 671a3d47b8a131e97ebfd5800c3194667a0f956e Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Sat, 15 Jan 2022 21:20:27 +0900 Subject: [PATCH] Move bindable binding to `LoadComplete` and remove unnecessary unbind --- .../Multiplayer/MultiplayerRoomSounds.cs | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerRoomSounds.cs b/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerRoomSounds.cs index e673bbcc8c..d467a32acb 100644 --- a/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerRoomSounds.cs +++ b/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerRoomSounds.cs @@ -24,8 +24,13 @@ namespace osu.Game.Screens.OnlinePlay.Multiplayer userJoinedSample = audio.Samples.Get(@"Multiplayer/player-joined"); userLeftSample = audio.Samples.Get(@"Multiplayer/player-left"); userKickedSample = audio.Samples.Get(@"Multiplayer/player-kicked"); + } - Host.ValueChanged += hostChanged; + protected override void LoadComplete() + { + base.LoadComplete(); + + Host.BindValueChanged(hostChanged); } protected override void UserJoined(MultiplayerRoomUser user) @@ -56,12 +61,5 @@ namespace osu.Game.Screens.OnlinePlay.Multiplayer hostChangedSample?.Play(); } - - protected override void Dispose(bool isDisposing) - { - base.Dispose(isDisposing); - - Host.ValueChanged -= hostChanged; - } } }