From 64a47ff85066be41c54f58cd7bebff40a9fd0278 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Tue, 11 Jan 2022 16:30:35 +0900
Subject: [PATCH] Allow `RealmArchiveModelManager` file operations to be
 performed on detached instances

---
 osu.Game/Stores/RealmArchiveModelManager.cs | 27 +++++++++++++++++----
 1 file changed, 22 insertions(+), 5 deletions(-)

diff --git a/osu.Game/Stores/RealmArchiveModelManager.cs b/osu.Game/Stores/RealmArchiveModelManager.cs
index 0b78071d16..00fc5bbb6f 100644
--- a/osu.Game/Stores/RealmArchiveModelManager.cs
+++ b/osu.Game/Stores/RealmArchiveModelManager.cs
@@ -9,6 +9,7 @@ using System.Threading;
 using System.Threading.Tasks;
 using osu.Framework.Platform;
 using osu.Game.Database;
+using osu.Game.Extensions;
 using osu.Game.IO.Archives;
 using osu.Game.Models;
 using osu.Game.Overlays.Notifications;
@@ -33,13 +34,29 @@ namespace osu.Game.Stores
         }
 
         public void DeleteFile(TModel item, RealmNamedFileUsage file) =>
-            item.Realm.Write(() => DeleteFile(item, file, item.Realm));
+            performFileOperation(item, managed => DeleteFile(managed, file, managed.Realm));
 
-        public void ReplaceFile(TModel item, RealmNamedFileUsage file, Stream contents)
-            => item.Realm.Write(() => ReplaceFile(file, contents, item.Realm));
+        public void ReplaceFile(TModel item, RealmNamedFileUsage file, Stream contents) =>
+            performFileOperation(item, managed => ReplaceFile(file, contents, managed.Realm));
 
-        public void AddFile(TModel item, Stream contents, string filename)
-            => item.Realm.Write(() => AddFile(item, contents, filename, item.Realm));
+        public void AddFile(TModel item, Stream contents, string filename) =>
+            performFileOperation(item, managed => AddFile(managed, contents, filename, managed.Realm));
+
+        private void performFileOperation(TModel item, Action<TModel> operation)
+        {
+            // While we are detaching so often, this seems like the easiest way to keep things in sync.
+            // This method should be removed as soon as all the surrounding pieces support non-detached operations.
+            if (!item.IsManaged)
+            {
+                var managed = ContextFactory.Context.Find<TModel>(item.ID);
+                managed.Realm.Write(() => operation(managed));
+
+                item.Files.Clear();
+                item.Files.AddRange(managed.Files.Detach());
+            }
+            else
+                operation(item);
+        }
 
         /// <summary>
         /// Delete a file from within an ongoing realm transaction.