h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 15:33:05 +08:00
Code Issues Releases Wiki Activity

Ensure beatmap set is always detached when updating

Browse Source 
Slight performance improvement by doing the detach as early as possible.
This commit is contained in:
Dean Herbert 2024-07-09 16:58:35 +09:00
parent e734cdfee5
commit 63b4327978
No known key found for this signature in database
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
osu.Game/Screens/Select/BeatmapCarousel.cs
View File

@ -417,16 +417,23 @@ namespace osu.Game.Screens.Select
} }
} }
public void UpdateBeatmapSet(BeatmapSetInfo beatmapSet) => Schedule(() => public void UpdateBeatmapSet(BeatmapSetInfo beatmapSet)
{ {
updateBeatmapSet(beatmapSet); beatmapSet = beatmapSet.Detach();
invalidateAfterChange();
}); Schedule(() =>
{
updateBeatmapSet(beatmapSet);
invalidateAfterChange();
});
}
private void updateBeatmapSet(BeatmapSetInfo beatmapSet) private void updateBeatmapSet(BeatmapSetInfo beatmapSet)
{ {
beatmapSet = beatmapSet.Detach();
originalBeatmapSetsDetached.RemoveAll(set => set.ID == beatmapSet.ID); originalBeatmapSetsDetached.RemoveAll(set => set.ID == beatmapSet.ID);
originalBeatmapSetsDetached.Add(beatmapSet.Detach()); originalBeatmapSetsDetached.Add(beatmapSet);
var newSets = new List<CarouselBeatmapSet>(); var newSets = new List<CarouselBeatmapSet>();