h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-19 09:12:58 +08:00
Code Issues Releases Wiki Activity

Merge pull request #15916 from peppy/dont-send-unnecessary-params-beatmap-get

Browse Source 
Avoid sending empty parameters in `GetBeatmapRequest`
This commit is contained in:
Dan Balasescu 2021-12-03 17:33:58 +09:00 committed by GitHub
commit 637852a2aa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
osu.Game/Online/API/Requests/GetBeatmapRequest.cs
View File

@ -26,9 +26,12 @@ namespace osu.Game.Online.API.Requests
{ {
var request = base.CreateWebRequest(); var request = base.CreateWebRequest();
request.AddParameter(@"id", beatmapInfo.OnlineID.ToString()); if (beatmapInfo.OnlineID > 0)
request.AddParameter(@"checksum", beatmapInfo.MD5Hash); request.AddParameter(@"id", beatmapInfo.OnlineID.ToString());
request.AddParameter(@"filename", filename); if (!string.IsNullOrEmpty(beatmapInfo.MD5Hash))
request.AddParameter(@"checksum", beatmapInfo.MD5Hash);
if (!string.IsNullOrEmpty(filename))
request.AddParameter(@"filename", filename);
return request; return request;
} }