h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 14:03:21 +08:00
Code Issues Releases Wiki Activity

Remove unnecessary code and fix double nesting causing filtering to not work

Browse Source
This commit is contained in:
Dean Herbert 2022-01-03 12:53:58 +09:00
parent 623d6d6d2d
commit 6356180b6a
1 changed files with 6 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
osu.Game/Overlays/Settings/Sections/Gameplay/AudioSettings.cs
View File

@ -2,12 +2,10 @@
// See the LICENCE file in the repository root for full licence text. // See the LICENCE file in the repository root for full licence text.
using osu.Framework.Allocation; using osu.Framework.Allocation;
using osu.Framework.Bindables;
using osu.Framework.Graphics; using osu.Framework.Graphics;
using osu.Framework.Localisation; using osu.Framework.Localisation;
using osu.Game.Configuration; using osu.Game.Configuration;
using osu.Game.Localisation; using osu.Game.Localisation;
using osu.Framework.Graphics.Containers;
namespace osu.Game.Overlays.Settings.Sections.Gameplay namespace osu.Game.Overlays.Settings.Sections.Gameplay
{ {
@ -15,32 +13,18 @@ namespace osu.Game.Overlays.Settings.Sections.Gameplay
{ {
protected override LocalisableString Header => GameplaySettingsStrings.AudioHeader; protected override LocalisableString Header => GameplaySettingsStrings.AudioHeader;
private Bindable<float> positionalHitsoundsLevel;
private FillFlowContainer<SettingsSlider<float>> positionalHitsoundsSettings;
[BackgroundDependencyLoader] [BackgroundDependencyLoader]
private void load(OsuConfigManager config, OsuConfigManager osuConfig) private void load(OsuConfigManager config, OsuConfigManager osuConfig)
{ {
positionalHitsoundsLevel = osuConfig.GetBindable<float>(OsuSetting.PositionalHitsoundsLevel);
Children = new Drawable[] Children = new Drawable[]
{
positionalHitsoundsSettings = new FillFlowContainer<SettingsSlider<float>>
{
Direction = FillDirection.Vertical,
RelativeSizeAxes = Axes.X,
AutoSizeAxes = Axes.Y,
Masking = true,
Children = new[]
{ {
new SettingsSlider<float> new SettingsSlider<float>
{ {
LabelText = AudioSettingsStrings.PositionalLevel, LabelText = AudioSettingsStrings.PositionalLevel,
Current = positionalHitsoundsLevel, Keywords = new[] { @"positional", @"balance" },
Current = osuConfig.GetBindable<float>(OsuSetting.PositionalHitsoundsLevel),
KeyboardStep = 0.01f, KeyboardStep = 0.01f,
DisplayAsPercentage = true DisplayAsPercentage = true
}
}
}, },
new SettingsCheckbox new SettingsCheckbox
{ {