h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-28 06:03:08 +08:00
Code Issues Releases Wiki Activity

Remove wait steps and add coverage of non-looping sounds

Browse Source
This commit is contained in:
Dean Herbert 2020-07-27 18:02:14 +09:00
parent 12368ace3b
commit 5fd73795f6
1 changed files with 28 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
osu.Game.Tests/Visual/Gameplay/TestSceneSkinnableSound.cs
View File

@ -31,13 +31,7 @@ namespace osu.Game.Tests.Visual.Gameplay
{ {
Clock = gameplayClock, Clock = gameplayClock,
RelativeSizeAxes = Axes.Both, RelativeSizeAxes = Axes.Both,
Children = new Drawable[] Child = skinnableSound = new SkinnableSound(new SampleInfo("normal-sliderslide"))
{
skinnableSound = new SkinnableSound(new SampleInfo("normal-sliderslide"))
{
Looping = true
}
}
}, },
}; };
} }
@ -46,27 +40,47 @@ namespace osu.Game.Tests.Visual.Gameplay
public void TestStoppedSoundDoesntResumeAfterPause() public void TestStoppedSoundDoesntResumeAfterPause()
{ {
DrawableSample sample = null; DrawableSample sample = null;
AddStep("start sample", () => AddStep("start sample with looping", () =>
{ {
skinnableSound.Looping = true;
skinnableSound.Play(); skinnableSound.Play();
sample = skinnableSound.ChildrenOfType<DrawableSample>().First(); sample = skinnableSound.ChildrenOfType<DrawableSample>().First();
}); });
AddUntilStep("wait for sample to start playing", () => sample.Playing); AddAssert("sample playing", () => sample.Playing);
AddStep("stop sample", () => skinnableSound.Stop()); AddStep("stop sample", () => skinnableSound.Stop());
AddUntilStep("wait for sample to stop playing", () => !sample.Playing); AddAssert("sample not playing", () => !sample.Playing);
AddStep("pause gameplay clock", () => gameplayClock.IsPaused.Value = true); AddStep("pause gameplay clock", () => gameplayClock.IsPaused.Value = true);
AddStep("resume gameplay clock", () => gameplayClock.IsPaused.Value = false); AddStep("resume gameplay clock", () => gameplayClock.IsPaused.Value = false);
AddWaitStep("wait a bit", 5);
AddAssert("sample not playing", () => !sample.Playing); AddAssert("sample not playing", () => !sample.Playing);
} }
[Test] [Test]
public void TestLoopingSoundResumesAfterPause() public void TestLoopingSoundResumesAfterPause()
{
DrawableSample sample = null;
AddStep("start sample with looping", () =>
{
skinnableSound.Looping = true;
skinnableSound.Play();
sample = skinnableSound.ChildrenOfType<DrawableSample>().First();
});
AddAssert("sample playing", () => sample.Playing);
AddStep("pause gameplay clock", () => gameplayClock.IsPaused.Value = true);
AddAssert("sample not playing", () => !sample.Playing);
AddStep("resume gameplay clock", () => gameplayClock.IsPaused.Value = false);
AddUntilStep("wait for sample to start playing", () => sample.Playing);
}
[Test]
public void TestNonLoopingStopsWithPause()
{ {
DrawableSample sample = null; DrawableSample sample = null;
AddStep("start sample", () => AddStep("start sample", () =>
@ -75,13 +89,13 @@ namespace osu.Game.Tests.Visual.Gameplay
sample = skinnableSound.ChildrenOfType<DrawableSample>().First(); sample = skinnableSound.ChildrenOfType<DrawableSample>().First();
}); });
AddUntilStep("wait for sample to start playing", () => sample.Playing); AddAssert("sample playing", () => sample.Playing);
AddStep("pause gameplay clock", () => gameplayClock.IsPaused.Value = true); AddStep("pause gameplay clock", () => gameplayClock.IsPaused.Value = true);
AddUntilStep("wait for sample to stop playing", () => !sample.Playing); AddAssert("sample not playing", () => !sample.Playing);
AddStep("resume gameplay clock", () => gameplayClock.IsPaused.Value = false); AddStep("resume gameplay clock", () => gameplayClock.IsPaused.Value = false);
AddUntilStep("wait for sample to start playing", () => sample.Playing); AddAssert("sample not playing", () => !sample.Playing);
} }
} }
} }