From 5fc5d0bd5ff229aeaa0cd4cf1bc2c3482d827a9c Mon Sep 17 00:00:00 2001 From: clayton Date: Sun, 10 Aug 2025 07:15:20 -0700 Subject: [PATCH] Fix tick hits in non-legacy skins --- .../Objects/Drawables/DrawableOsuJudgement.cs | 4 +++- .../Skinning/Argon/OsuArgonSkinTransformer.cs | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuJudgement.cs b/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuJudgement.cs index 8b3fcb23cd..05c03cb578 100644 --- a/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuJudgement.cs +++ b/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuJudgement.cs @@ -87,7 +87,9 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables base.ApplyHitAnimations(); } - protected override Drawable CreateDefaultJudgement(HitResult result) => new OsuJudgementPiece(result); + protected override Drawable CreateDefaultJudgement(HitResult result) => + // Tick hits don't show a judgement by default + result.IsHit() && result.IsTick() ? Empty() : new OsuJudgementPiece(result); private partial class OsuJudgementPiece : DefaultJudgementPiece { diff --git a/osu.Game.Rulesets.Osu/Skinning/Argon/OsuArgonSkinTransformer.cs b/osu.Game.Rulesets.Osu/Skinning/Argon/OsuArgonSkinTransformer.cs index 2d1d5826b1..ecc0f3fd0a 100644 --- a/osu.Game.Rulesets.Osu/Skinning/Argon/OsuArgonSkinTransformer.cs +++ b/osu.Game.Rulesets.Osu/Skinning/Argon/OsuArgonSkinTransformer.cs @@ -29,6 +29,10 @@ namespace osu.Game.Rulesets.Osu.Skinning.Argon switch (result) { + case HitResult.LargeTickHit: + case HitResult.SliderTailHit: + return null; + case HitResult.IgnoreMiss: case HitResult.LargeTickMiss: return new ArgonJudgementPieceSliderTickMiss(result);