h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 19:22:54 +08:00
Code Issues Releases Wiki Activity

Apply suggestion from code review

Browse Source 
Co-authored-by: frenzibyte <frenzibyte@gmail.com>
This commit is contained in:
kj415j45 2021-07-18 09:55:40 +08:00
parent bf6204f64e
commit 5fc1397564
4 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game/Overlays/Changelog/ChangelogHeader.cs
View File

@ -24,7 +24,7 @@ namespace osu.Game.Overlays.Changelog
public ChangelogUpdateStreamControl Streams; public ChangelogUpdateStreamControl Streams;
public LocalisableString ListingString => LayoutStrings.HeaderChangelogIndex; public static LocalisableString ListingString => LayoutStrings.HeaderChangelogIndex;
private Box streamsBackground; private Box streamsBackground;

3
osu.Game/Overlays/News/NewsHeader.cs
View File

@ -12,7 +12,8 @@ namespace osu.Game.Overlays.News
{ {
public class NewsHeader : BreadcrumbControlOverlayHeader public class NewsHeader : BreadcrumbControlOverlayHeader
{ {
public LocalisableString FrontPageString => osu.Game.Resources.Localisation.Web.NewsStrings.IndexTitleInfo; public static LocalisableString FrontPageString => NewsStrings.IndexTitleInfo;
public Action ShowFrontPage; public Action ShowFrontPage;
private readonly Bindable<string> article = new Bindable<string>(); private readonly Bindable<string> article = new Bindable<string>();

1
osu.Game/Overlays/Rankings/RankingsOverlayHeader.cs
View File

@ -72,5 +72,4 @@ namespace osu.Game.Overlays.Rankings
} }
} }
} }
} }

3
osu.Game/Overlays/Wiki/WikiHeader.cs
View File

@ -14,7 +14,8 @@ namespace osu.Game.Overlays.Wiki
public class WikiHeader : BreadcrumbControlOverlayHeader public class WikiHeader : BreadcrumbControlOverlayHeader
{ {
private const string index_path = "Main_Page"; private const string index_path = "Main_Page";
public LocalisableString IndexPageString => LayoutStrings.HeaderHelpIndex;
public static LocalisableString IndexPageString => LayoutStrings.HeaderHelpIndex;
public readonly Bindable<APIWikiPage> WikiPageData = new Bindable<APIWikiPage>(); public readonly Bindable<APIWikiPage> WikiPageData = new Bindable<APIWikiPage>();