diff --git a/osu.Game.Tests/Visual/Background/TestSceneUserDimContainer.cs b/osu.Game.Tests/Visual/Background/TestSceneUserDimContainer.cs
index 03206402c3..8eb256538a 100644
--- a/osu.Game.Tests/Visual/Background/TestSceneUserDimContainer.cs
+++ b/osu.Game.Tests/Visual/Background/TestSceneUserDimContainer.cs
@@ -47,7 +47,10 @@ namespace osu.Game.Tests.Visual.Background
lightenDuringBreaks.Value = false;
});
- [TestCase(0.6f, 0.3f)]
+ private const float test_user_dim = 0.6f;
+ private const float test_user_dim_lightened = test_user_dim - UserDimContainer.BREAK_LIGHTEN_AMOUNT;
+
+ [TestCase(test_user_dim, test_user_dim_lightened)]
[TestCase(0.2f, 0.0f)]
[TestCase(0.0f, 0.0f)]
public void TestBreakLightening(float userDim, float expectedBreakDim)
@@ -64,26 +67,26 @@ namespace osu.Game.Tests.Visual.Background
[Test]
public void TestEnableSettingDuringBreak()
{
- AddStep("set dim level 0.6", () => container.UserDimLevel.Value = 0.6f);
+ AddStep("set dim level 0.6", () => container.UserDimLevel.Value = test_user_dim);
AddStep("set break", () => isBreakTime.Value = true);
- AddUntilStep("not lightened", () => container.DimEqual(0.6f));
+ AddUntilStep("not lightened", () => container.DimEqual(test_user_dim));
AddStep("set lighten during break", () => lightenDuringBreaks.Value = true);
- AddUntilStep("has lightened", () => container.DimEqual(0.3f));
+ AddUntilStep("has lightened", () => container.DimEqual(test_user_dim_lightened));
}
[Test]
public void TestDisableSettingDuringBreak()
{
- AddStep("set dim level 0.6", () => container.UserDimLevel.Value = 0.6f);
+ AddStep("set dim level 0.6", () => container.UserDimLevel.Value = test_user_dim);
AddStep("set lighten during break", () => lightenDuringBreaks.Value = true);
AddStep("set break", () => isBreakTime.Value = true);
- AddUntilStep("has lightened", () => container.DimEqual(0.3f));
+ AddUntilStep("has lightened", () => container.DimEqual(test_user_dim_lightened));
AddStep("clear lighten during break", () => lightenDuringBreaks.Value = false);
- AddUntilStep("not lightened", () => container.DimEqual(0.6f));
+ AddUntilStep("not lightened", () => container.DimEqual(test_user_dim));
AddStep("clear break", () => isBreakTime.Value = false);
- AddUntilStep("not lightened", () => container.DimEqual(0.6f));
+ AddUntilStep("not lightened", () => container.DimEqual(test_user_dim));
}
private class TestUserDimContainer : UserDimContainer
diff --git a/osu.Game/Graphics/Containers/UserDimContainer.cs b/osu.Game/Graphics/Containers/UserDimContainer.cs
index dcc8a52e9d..e67cd94d5c 100644
--- a/osu.Game/Graphics/Containers/UserDimContainer.cs
+++ b/osu.Game/Graphics/Containers/UserDimContainer.cs
@@ -19,7 +19,7 @@ namespace osu.Game.Graphics.Containers
///
/// Amount of lightening to apply to current dim level during break times.
///
- private const float break_lighten_amount = 0.3f;
+ public const float BREAK_LIGHTEN_AMOUNT = 0.3f;
protected const double BACKGROUND_FADE_DURATION = 800;
@@ -52,7 +52,7 @@ namespace osu.Game.Graphics.Containers
protected Bindable ShowVideo { get; private set; }
- private float breakLightening => LightenDuringBreaks.Value && IsBreakTime.Value ? break_lighten_amount : 0;
+ private float breakLightening => LightenDuringBreaks.Value && IsBreakTime.Value ? BREAK_LIGHTEN_AMOUNT : 0;
protected float DimLevel => Math.Max(EnableUserDim.Value ? (float)UserDimLevel.Value - breakLightening : 0, 0);
protected override Container Content => dimContent;