h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-13 19:54:15 +08:00
Code Issues Releases Wiki Activity

Fix rider EAP new naming inspections

Browse Source
This commit is contained in:
Dean Herbert
2025-05-25 04:59:07 +09:00
Unverified
parent 77953aaee4
commit 5e3fd7a42a
15 changed files with 69 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game.Rulesets.Osu/Mods/OsuModFreezeFrame.cs
+4 -1
View File
@@ -43,7 +43,10 @@ namespace osu.Game.Rulesets.Osu.Mods
foreach (var obj in beatmap.HitObjects.OfType<OsuHitObject>())
{
if (obj.NewCombo) { lastNewComboTime = obj.StartTime; }
if (obj.NewCombo)
{
lastNewComboTime = obj.StartTime;
}
applyFadeInAdjustment(obj);
}
osu.Game.Tests/Visual/Gameplay/TestSceneClicksPerSecondCalculator.cs
+4 -1
View File
@@ -108,7 +108,10 @@ namespace osu.Game.Tests.Visual.Gameplay
public bool IsRunning => true;
public double TrueGameplayRate { set => adjustableAudioComponent.Tempo.Value = value; }
public double TrueGameplayRate
{
set => adjustableAudioComponent.Tempo.Value = value;
}
private readonly AudioAdjustments adjustableAudioComponent = new AudioAdjustments();
osu.Game/Overlays/Chat/Listing/ChannelListingItem.cs
+5 -1
View File
@@ -31,7 +31,11 @@ namespace osu.Game.Overlays.Chat.Listing
public bool FilteringActive { get; set; }
public IEnumerable<LocalisableString> FilterTerms => new LocalisableString[] { Channel.Name, Channel.Topic ?? string.Empty };
public bool MatchingFilter { set => this.FadeTo(value ? 1f : 0f, 100); }
public bool MatchingFilter
{
set => this.FadeTo(value ? 1f : 0f, 100);
}
protected override HoverSounds CreateHoverSounds(HoverSampleSet sampleSet) => new HoverSounds();
osu.Game/Overlays/Dashboard/Friends/FriendsList.cs
+4 -1
View File
@@ -207,7 +207,10 @@ namespace osu.Game.Overlays.Dashboard.Friends
}
}
bool IFilterable.FilteringActive { set { } }
bool IFilterable.FilteringActive
{
set { }
}
}
}
}
osu.Game/Overlays/Mods/ModSelectPanel.cs
+4 -1
View File
@@ -300,7 +300,10 @@ namespace osu.Game.Overlays.Mods
}
}
public bool FilteringActive { set { } }
public bool FilteringActive
{
set { }
}
#endregion
}
osu.Game/Screens/Edit/Timing/WaveformComparisonDisplay.cs
+9 -2
View File
@@ -356,8 +356,15 @@ namespace osu.Game.Screens.Edit.Timing
waveformGraph.Waveform = beatmap.Value.Waveform;
}
public int BeatIndex { set => beatIndexText.Text = value.ToString(); }
public Vector2 WaveformScale { set => waveformGraph.Scale = value; }
public int BeatIndex
{
set => beatIndexText.Text = value.ToString();
}
public Vector2 WaveformScale
{
set => waveformGraph.Scale = value;
}
public void WaveformOffsetTo(float value, bool animated) =>
this.TransformTo(nameof(waveformOffset), value, animated ? 300 : 0, Easing.OutQuint);
osu.Game/Screens/OnlinePlay/FooterButtonFreeMods.cs
+4 -1
View File
@@ -28,7 +28,10 @@ namespace osu.Game.Screens.OnlinePlay
protected override bool IsActive => FreeMods.Value.Count > 0;
public new Action Action { set => throw new NotSupportedException("The click action is handled by the button itself."); }
public new Action Action
{
set => throw new NotSupportedException("The click action is handled by the button itself.");
}
private OsuSpriteText count = null!;
private Circle circle = null!;
osu.Game/Screens/OnlinePlay/FooterButtonFreestyle.cs
+4 -1
View File
@@ -21,7 +21,10 @@ namespace osu.Game.Screens.OnlinePlay
protected override bool IsActive => Freestyle.Value;
public new Action Action { set => throw new NotSupportedException("The click action is handled by the button itself."); }
public new Action Action
{
set => throw new NotSupportedException("The click action is handled by the button itself.");
}
private OsuSpriteText text = null!;
private Circle circle = null!;
osu.Game/Screens/Play/BeatmapMetadataDisplay.cs
-1
View File
@@ -4,7 +4,6 @@
#nullable disable
using System.Collections.Generic;
using System.Diagnostics;
using osu.Framework.Allocation;
using osu.Framework.Bindables;
using osu.Framework.Graphics;
osu.Game/Screens/Play/HUD/JudgementCounter/JudgementCounter.cs
+4 -1
View File
@@ -20,7 +20,10 @@ namespace osu.Game.Screens.Play.HUD.JudgementCounter
public readonly JudgementCount Result;
public JudgementCounter(JudgementCount result) => Result = result;
public JudgementCounter(JudgementCount result)
{
Result = result;
}
public OsuSpriteText ResultName = null!;
private FillFlowContainer flowContainer = null!;
osu.Game/Screens/Ranking/UserTagControl_AddTagsPopover.cs
+13 -3
View File
@@ -140,7 +140,10 @@ namespace osu.Game.Screens.Ranking
set => Alpha = value ? 1 : 0;
}
public bool FilteringActive { set { } }
public bool FilteringActive
{
set { }
}
public GroupFlow(string? name)
{
@@ -245,8 +248,15 @@ namespace osu.Game.Screens.Ranking
public IEnumerable<LocalisableString> FilterTerms => [Tag.FullName, Tag.Description];
public bool MatchingFilter { set => Alpha = value ? 1 : 0; }
public bool FilteringActive { set { } }
public bool MatchingFilter
{
set => Alpha = value ? 1 : 0;
}
public bool FilteringActive
{
set { }
}
protected override void LoadComplete()
{
osu.Game/Screens/SelectV2/BeatmapTitleWedge_DifficultyDisplay.cs
-1
View File
@@ -8,7 +8,6 @@ using System.Threading;
using System.Threading.Tasks;
using osu.Framework.Allocation;
using osu.Framework.Bindables;
using osu.Framework.Extensions;
using osu.Framework.Extensions.Color4Extensions;
using osu.Framework.Graphics;
using osu.Framework.Graphics.Containers;
osu.Game/Screens/SelectV2/Panel.cs
+8 -2
View File
@@ -45,9 +45,15 @@ namespace osu.Game.Screens.SelectV2
protected Container Content { get; private set; } = null!;
public Drawable Background { set => backgroundContainer.Child = value; }
public Drawable Background
{
set => backgroundContainer.Child = value;
}
public Drawable Icon { set => iconContainer.Child = value; }
public Drawable Icon
{
set => iconContainer.Child = value;
}
private Color4? accentColour;
osu.Game/Utils/SentryLogger.cs
+4 -1
View File
@@ -58,7 +58,10 @@ namespace osu.Game.Utils
Logger.NewEntry += processLogEntry;
}
~SentryLogger() => Dispose(false);
~SentryLogger()
{
Dispose(false);
}
public void AttachUser(IBindable<APIUser> user)
{
osu.sln.DotSettings
+2 -1
View File
@@ -304,7 +304,7 @@
<s:Int64 x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/BLANK_LINES_BEFORE_BLOCK_STATEMENTS/@EntryValue">1</s:Int64>
<s:Int64 x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/BLANK_LINES_BEFORE_CASE/@EntryValue">1</s:Int64>
<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/CASE_BLOCK_BRACES/@EntryValue">NEXT_LINE</s:String>
<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/EMPTY_BLOCK_STYLE/@EntryValue">MULTILINE</s:String>
<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/EMPTY_BLOCK_STYLE/@EntryValue">DO_NOT_CHANGE</s:String>
<s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/INDENT_NESTED_FOR_STMT/@EntryValue">True</s:Boolean>
<s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/INDENT_NESTED_FOREACH_STMT/@EntryValue">True</s:Boolean>
<s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/INDENT_NESTED_LOCK_STMT/@EntryValue">True</s:Boolean>
@@ -781,6 +781,7 @@ See the LICENCE file in the repository root for full licence text.&#xD;
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/PredefinedNamingRules/=PrivateStaticReadonly/@EntryIndexedValue">&lt;Policy Inspect="True" Prefix="" Suffix="" Style="aa_bb" /&gt;</s:String>
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/PredefinedNamingRules/=StaticReadonly/@EntryIndexedValue">&lt;Policy Inspect="True" Prefix="" Suffix="" Style="AA_BB" /&gt;</s:String>
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/PredefinedNamingRules/=TypeParameters/@EntryIndexedValue">&lt;Policy Inspect="True" Prefix="" Suffix="" Style="AaBb" /&gt;</s:String>
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/UserRules/=0c4c6401_002D2a1f_002D4db1_002Da21f_002D562f51542cf8/@EntryIndexedValue">&lt;Policy&gt;&lt;Descriptor Staticness="Any" AccessRightKinds="Protected, ProtectedInternal, Internal, Public, PrivateProtected, FileLocal" Description="Events"&gt;&lt;ElementKinds&gt;&lt;Kind Name="EVENT" /&gt;&lt;/ElementKinds&gt;&lt;/Descriptor&gt;&lt;Policy Inspect="True" WarnAboutPrefixesAndSuffixes="False" Prefix="" Suffix="" Style="AaBb" /&gt;&lt;/Policy&gt;</s:String>
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/UserRules/=15b5b1f1_002D457c_002D4ca6_002Db278_002D5615aedc07d3/@EntryIndexedValue">&lt;Policy&gt;&lt;Descriptor Staticness="Static" AccessRightKinds="Private" Description="Static readonly fields (private)"&gt;&lt;ElementKinds&gt;&lt;Kind Name="READONLY_FIELD" /&gt;&lt;/ElementKinds&gt;&lt;/Descriptor&gt;&lt;Policy Inspect="True" Prefix="" Suffix="" Style="aa_bb" /&gt;&lt;/Policy&gt;</s:String>
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/UserRules/=236f7aa5_002D7b06_002D43ca_002Dbf2a_002D9b31bfcff09a/@EntryIndexedValue">&lt;Policy&gt;&lt;Descriptor Staticness="Any" AccessRightKinds="Private" Description="Constant fields (private)"&gt;&lt;ElementKinds&gt;&lt;Kind Name="CONSTANT_FIELD" /&gt;&lt;/ElementKinds&gt;&lt;/Descriptor&gt;&lt;Policy Inspect="True" Prefix="" Suffix="" Style="aa_bb" /&gt;&lt;/Policy&gt;</s:String>
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/UserRules/=2c62818f_002D621b_002D4425_002Dadc9_002D78611099bfcb/@EntryIndexedValue">&lt;Policy&gt;&lt;Descriptor Staticness="Any" AccessRightKinds="Any" Description="Type parameters"&gt;&lt;ElementKinds&gt;&lt;Kind Name="TYPE_PARAMETER" /&gt;&lt;/ElementKinds&gt;&lt;/Descriptor&gt;&lt;Policy Inspect="True" Prefix="" Suffix="" Style="AaBb" /&gt;&lt;/Policy&gt;</s:String>