h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 16:52:54 +08:00
Code Issues Releases Wiki Activity

Improve performance with large numbers of panels visible

Browse Source
This commit is contained in:
Dean Herbert 2017-12-17 04:30:56 +09:00
parent c02ce16f47
commit 5d7413f19c
3 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game/Screens/Select/BeatmapCarousel.cs
View File

@ -483,11 +483,11 @@ namespace osu.Game.Screens.Select
{
DrawableCarouselItem item = Items[i];
if (!item.Item.Visible) continue;
// Only add if we're not already part of the content.
if (!scrollableContent.Contains(item))
{
if (!item.Item.Visible) continue;
// Makes sure headers are always _below_ items,
// and depth flows downward.
item.Depth = i + (item is DrawableCarouselBeatmapSet ? -Items.Count : 0);

12
osu.Game/Screens/Select/Carousel/CarouselGroupEagerSelect.cs
View File

@ -27,9 +27,19 @@ namespace osu.Game.Screens.Select.Carousel
private CarouselItem lastSelected;
/// <summary>
/// To avoid overhead during filter operations, we don't attempt any selections until after all
/// children have been filtered. This bool will be true during the base <see cref="Filter(FilterCriteria)"/>
/// operation.
/// </summary>
private bool filteringChildren;
public override void Filter(FilterCriteria criteria)
{
filteringChildren = true;
base.Filter(criteria);
filteringChildren = false;
attemptSelection();
}
@ -64,6 +74,8 @@ namespace osu.Game.Screens.Select.Carousel
private void attemptSelection()
{
if (filteringChildren) return;
// we only perform eager selection if we are a currently selected group.
if (State != CarouselItemState.Selected) return;

3
osu.Game/Screens/Select/Carousel/CarouselItem.cs
View File

@ -33,7 +33,8 @@ namespace osu.Game.Screens.Select.Carousel
if (InternalChildren != null)
foreach (var c in InternalChildren)
items.AddRange(c.Drawables);
// if (!c.Filtered) <- potential optimisation at the cost of no fade out animations.
items.AddRange(c.Drawables);
return items;
}