mirror of
https://github.com/ppy/osu.git
synced 2025-01-16 13:32:54 +08:00
Remove CreateCircle() - hitobjects should handle the addition of this to their hierarchy themselves.
CreateCircle() lends itself to a few issues: - It can't be used for drum roll ticks unless it returned a Container instead, at which point the method loses its meaning, and I would rather that constructed in the ctor. - Writing `return Accented ? new AccentedCirclePiece() : new CirclePiece()` in two places as the body of this method feels wrong - it's something I would expect to be taken care of in the base DrawableTaikoHitObject, but that leads back to #1. - Swells don't have an AccentedCirclePiece, so #2 becomes more problematic.
This commit is contained in:
parent
4762e043a0
commit
5bd9147661
@ -4,7 +4,6 @@
|
||||
using osu.Framework.Graphics;
|
||||
using osu.Game.Modes.Objects.Drawables;
|
||||
using osu.Game.Modes.Taiko.Judgements;
|
||||
using osu.Game.Modes.Taiko.Objects.Drawable.Pieces;
|
||||
|
||||
namespace osu.Game.Modes.Taiko.Objects.Drawable
|
||||
{
|
||||
@ -17,11 +16,6 @@ namespace osu.Game.Modes.Taiko.Objects.Drawable
|
||||
Origin = Anchor.Centre;
|
||||
|
||||
RelativePositionAxes = Axes.X;
|
||||
|
||||
Children = new[]
|
||||
{
|
||||
CreateCircle()
|
||||
};
|
||||
}
|
||||
|
||||
protected override void LoadComplete()
|
||||
@ -48,7 +42,5 @@ namespace osu.Game.Modes.Taiko.Objects.Drawable
|
||||
{
|
||||
UpdateScrollPosition(Time.Current);
|
||||
}
|
||||
|
||||
protected abstract CirclePiece CreateCircle();
|
||||
}
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user