h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 20:22:55 +08:00
Code Issues Releases Wiki Activity

Merge pull request #15243 from peppy/remove-beatmap-set-online-info-setters

Browse Source 
Remove unnecessary setters from `IBeatmapSetOnlineInfo` interface
This commit is contained in:
Dan Balasescu 2021-10-22 18:45:11 +09:00 committed by GitHub
commit 5b9eb52d44
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 33 additions and 97 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
osu.Game/Beatmaps/BeatmapSetInfo.cs
View File

@ -107,27 +107,15 @@ namespace osu.Game.Beatmaps
[NotMapped] [NotMapped]
[JsonIgnore] [JsonIgnore]
public DateTimeOffset Submitted public DateTimeOffset Submitted => OnlineInfo.Submitted;
{
get => OnlineInfo.Submitted;
set => OnlineInfo.Submitted = value;
}
[NotMapped] [NotMapped]
[JsonIgnore] [JsonIgnore]
public DateTimeOffset? Ranked public DateTimeOffset? Ranked => OnlineInfo.Ranked;
{
get => OnlineInfo.Ranked;
set => OnlineInfo.Ranked = value;
}
[NotMapped] [NotMapped]
[JsonIgnore] [JsonIgnore]
public DateTimeOffset? LastUpdated public DateTimeOffset? LastUpdated => OnlineInfo.LastUpdated;
{
get => OnlineInfo.LastUpdated;
set => OnlineInfo.LastUpdated = value;
}
[NotMapped] [NotMapped]
[JsonIgnore] [JsonIgnore]
@ -135,107 +123,55 @@ namespace osu.Game.Beatmaps
[NotMapped] [NotMapped]
[JsonIgnore] [JsonIgnore]
public bool HasExplicitContent public bool HasExplicitContent => OnlineInfo.HasExplicitContent;
{
get => OnlineInfo.HasExplicitContent;
set => OnlineInfo.HasExplicitContent = value;
}
[NotMapped] [NotMapped]
[JsonIgnore] [JsonIgnore]
public bool HasVideo public bool HasVideo => OnlineInfo.HasVideo;
{
get => OnlineInfo.HasVideo;
set => OnlineInfo.HasVideo = value;
}
[NotMapped] [NotMapped]
[JsonIgnore] [JsonIgnore]
public bool HasStoryboard public bool HasStoryboard => OnlineInfo.HasStoryboard;
{
get => OnlineInfo.HasStoryboard;
set => OnlineInfo.HasStoryboard = value;
}
[NotMapped] [NotMapped]
[JsonIgnore] [JsonIgnore]
public BeatmapSetOnlineCovers Covers public BeatmapSetOnlineCovers Covers => OnlineInfo.Covers;
{
get => OnlineInfo.Covers;
set => OnlineInfo.Covers = value;
}
[NotMapped] [NotMapped]
[JsonIgnore] [JsonIgnore]
public string Preview public string Preview => OnlineInfo.Preview;
{
get => OnlineInfo.Preview;
set => OnlineInfo.Preview = value;
}
[NotMapped] [NotMapped]
[JsonIgnore] [JsonIgnore]
public double BPM public double BPM => OnlineInfo.BPM;
{
get => OnlineInfo.BPM;
set => OnlineInfo.BPM = value;
}
[NotMapped] [NotMapped]
[JsonIgnore] [JsonIgnore]
public int PlayCount public int PlayCount => OnlineInfo.PlayCount;
{
get => OnlineInfo.PlayCount;
set => OnlineInfo.PlayCount = value;
}
[NotMapped] [NotMapped]
[JsonIgnore] [JsonIgnore]
public int FavouriteCount public int FavouriteCount => OnlineInfo.FavouriteCount;
{
get => OnlineInfo.FavouriteCount;
set => OnlineInfo.FavouriteCount = value;
}
[NotMapped] [NotMapped]
[JsonIgnore] [JsonIgnore]
public bool HasFavourited public bool HasFavourited => OnlineInfo.HasFavourited;
{
get => OnlineInfo.HasFavourited;
set => OnlineInfo.HasFavourited = value;
}
[NotMapped] [NotMapped]
[JsonIgnore] [JsonIgnore]
public BeatmapSetOnlineAvailability Availability public BeatmapSetOnlineAvailability Availability => OnlineInfo.Availability;
{
get => OnlineInfo.Availability;
set => OnlineInfo.Availability = value;
}
[NotMapped] [NotMapped]
[JsonIgnore] [JsonIgnore]
public BeatmapSetOnlineGenre Genre public BeatmapSetOnlineGenre Genre => OnlineInfo.Genre;
{
get => OnlineInfo.Genre;
set => OnlineInfo.Genre = value;
}
[NotMapped] [NotMapped]
[JsonIgnore] [JsonIgnore]
public BeatmapSetOnlineLanguage Language public BeatmapSetOnlineLanguage Language => OnlineInfo.Language;
{
get => OnlineInfo.Language;
set => OnlineInfo.Language = value;
}
[NotMapped] [NotMapped]
[JsonIgnore] [JsonIgnore]
public int? TrackId public int? TrackId => OnlineInfo?.TrackId;
{
get => OnlineInfo.TrackId;
set => OnlineInfo.TrackId = value;
}
#endregion #endregion
} }

34
osu.Game/Beatmaps/IBeatmapSetOnlineInfo.cs
View File

@ -15,87 +15,87 @@ namespace osu.Game.Beatmaps
/// <summary> /// <summary>
/// The date this beatmap set was submitted to the online listing. /// The date this beatmap set was submitted to the online listing.
/// </summary> /// </summary>
DateTimeOffset Submitted { get; set; } DateTimeOffset Submitted { get; }
/// <summary> /// <summary>
/// The date this beatmap set was ranked. /// The date this beatmap set was ranked.
/// </summary> /// </summary>
DateTimeOffset? Ranked { get; set; } DateTimeOffset? Ranked { get; }
/// <summary> /// <summary>
/// The date this beatmap set was last updated. /// The date this beatmap set was last updated.
/// </summary> /// </summary>
DateTimeOffset? LastUpdated { get; set; } DateTimeOffset? LastUpdated { get; }
/// <summary> /// <summary>
/// The status of this beatmap set. /// The status of this beatmap set.
/// </summary> /// </summary>
BeatmapSetOnlineStatus Status { get; set; } BeatmapSetOnlineStatus Status { get; }
/// <summary> /// <summary>
/// Whether or not this beatmap set has explicit content. /// Whether or not this beatmap set has explicit content.
/// </summary> /// </summary>
bool HasExplicitContent { get; set; } bool HasExplicitContent { get; }
/// <summary> /// <summary>
/// Whether or not this beatmap set has a background video. /// Whether or not this beatmap set has a background video.
/// </summary> /// </summary>
bool HasVideo { get; set; } bool HasVideo { get; }
/// <summary> /// <summary>
/// Whether or not this beatmap set has a storyboard. /// Whether or not this beatmap set has a storyboard.
/// </summary> /// </summary>
bool HasStoryboard { get; set; } bool HasStoryboard { get; }
/// <summary> /// <summary>
/// The different sizes of cover art for this beatmap set. /// The different sizes of cover art for this beatmap set.
/// </summary> /// </summary>
BeatmapSetOnlineCovers Covers { get; set; } BeatmapSetOnlineCovers Covers { get; }
/// <summary> /// <summary>
/// A small sample clip of this beatmap set's song. /// A small sample clip of this beatmap set's song.
/// </summary> /// </summary>
string Preview { get; set; } string Preview { get; }
/// <summary> /// <summary>
/// The beats per minute of this beatmap set's song. /// The beats per minute of this beatmap set's song.
/// </summary> /// </summary>
double BPM { get; set; } double BPM { get; }
/// <summary> /// <summary>
/// The amount of plays this beatmap set has. /// The amount of plays this beatmap set has.
/// </summary> /// </summary>
int PlayCount { get; set; } int PlayCount { get; }
/// <summary> /// <summary>
/// The amount of people who have favourited this beatmap set. /// The amount of people who have favourited this beatmap set.
/// </summary> /// </summary>
int FavouriteCount { get; set; } int FavouriteCount { get; }
/// <summary> /// <summary>
/// Whether this beatmap set has been favourited by the current user. /// Whether this beatmap set has been favourited by the current user.
/// </summary> /// </summary>
bool HasFavourited { get; set; } bool HasFavourited { get; }
/// <summary> /// <summary>
/// The availability of this beatmap set. /// The availability of this beatmap set.
/// </summary> /// </summary>
BeatmapSetOnlineAvailability Availability { get; set; } BeatmapSetOnlineAvailability Availability { get; }
/// <summary> /// <summary>
/// The song genre of this beatmap set. /// The song genre of this beatmap set.
/// </summary> /// </summary>
BeatmapSetOnlineGenre Genre { get; set; } BeatmapSetOnlineGenre Genre { get; }
/// <summary> /// <summary>
/// The song language of this beatmap set. /// The song language of this beatmap set.
/// </summary> /// </summary>
BeatmapSetOnlineLanguage Language { get; set; } BeatmapSetOnlineLanguage Language { get; }
/// <summary> /// <summary>
/// The track ID of this beatmap set. /// The track ID of this beatmap set.
/// Non-null only if the track is linked to a featured artist track entry. /// Non-null only if the track is linked to a featured artist track entry.
/// </summary> /// </summary>
int? TrackId { get; set; } int? TrackId { get; }
} }
} }