h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-14 19:22:56 +08:00
Code Issues Releases Wiki Activity

Fix SPM counter immediately disappearing on completion of spinners

Browse Source
This commit is contained in:
Dean Herbert 2021-03-09 16:43:44 +09:00
parent 296afd2d17
commit 5a6864eb78
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game.Rulesets.Osu/Objects/Drawables/DrawableSpinner.cs
View File

@ -109,6 +109,9 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
base.OnFree(); base.OnFree();
spinningSample.Samples = null; spinningSample.Samples = null;
// the counter handles its own fade in (when spinning begins) so we should only be responsible for resetting it here, for pooling.
SpmCounter.Hide();
} }
protected override void LoadSamples() protected override void LoadSamples()

5
osu.Game.Rulesets.Osu/Skinning/Default/SpinnerSpmCounter.cs
View File

@ -21,6 +21,11 @@ namespace osu.Game.Rulesets.Osu.Skinning.Default
private readonly OsuSpriteText spmText; private readonly OsuSpriteText spmText;
public override void ApplyTransformsAt(double time, bool propagateChildren = false)
{
// handles own fade in state.
}
public SpinnerSpmCounter() public SpinnerSpmCounter()
{ {
Children = new Drawable[] Children = new Drawable[]