h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-15 02:42:54 +08:00
Code Issues Releases Wiki Activity

Fix sound duplication due to checkbox

Browse Source
This commit is contained in:
smoogipoo 2021-02-02 21:29:00 +09:00
parent f25535548a
commit 5a56e2ba4b
2 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
osu.Game/Graphics/UserInterface/OsuCheckbox.cs
View File

@ -18,6 +18,11 @@ namespace osu.Game.Graphics.UserInterface
public Color4 UncheckedColor { get; set; } = Color4.White; public Color4 UncheckedColor { get; set; } = Color4.White;
public int FadeDuration { get; set; } public int FadeDuration { get; set; }
/// <summary>
/// Whether to play sounds when the state changes as a result of user interaction.
/// </summary>
protected virtual bool PlaySoundsOnUserChange => true;
public string LabelText public string LabelText
{ {
set set
@ -96,10 +101,14 @@ namespace osu.Game.Graphics.UserInterface
protected override void OnUserChange(bool value) protected override void OnUserChange(bool value)
{ {
base.OnUserChange(value); base.OnUserChange(value);
if (value)
sampleChecked?.Play(); if (PlaySoundsOnUserChange)
else {
sampleUnchecked?.Play(); if (value)
sampleChecked?.Play();
else
sampleUnchecked?.Play();
}
} }
} }
} }

2
osu.Game/Screens/OnlinePlay/FreeModSelectOverlay.cs
View File

@ -110,6 +110,8 @@ namespace osu.Game.Screens.OnlinePlay
{ {
public Action<bool> Changed; public Action<bool> Changed;
protected override bool PlaySoundsOnUserChange => false;
protected override void OnUserChange(bool value) protected override void OnUserChange(bool value)
{ {
base.OnUserChange(value); base.OnUserChange(value);