From 59ec6ed2eb3a3c109fe80ca377d129d66832b353 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bart=C5=82omiej=20Dach?= Date: Mon, 18 Aug 2025 08:56:35 +0200 Subject: [PATCH] Stop fail sample when rewinding to before it in replay closes https://github.com/ppy/osu/issues/34688 I originally wrote it this way semi-intentionally because I thought cutting out the sample was worse than letting it play out, but I also forgot that people use like seventy hour long fail samples. --- osu.Game/Screens/Play/ReplayFailIndicator.cs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/osu.Game/Screens/Play/ReplayFailIndicator.cs b/osu.Game/Screens/Play/ReplayFailIndicator.cs index f6c6902552..769a84dce4 100644 --- a/osu.Game/Screens/Play/ReplayFailIndicator.cs +++ b/osu.Game/Screens/Play/ReplayFailIndicator.cs @@ -155,8 +155,11 @@ namespace osu.Game.Screens.Play failSample.Play(); } - if (Time.Current < failTime) + if (Time.Current < failTime && failSamplePlaybackInitiated) + { failSamplePlaybackInitiated = false; + failSample.Stop(); + } } protected override void Dispose(bool isDisposing)