h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-21 15:43:36 +08:00
Code Issues Releases Wiki Activity

Fix switching storyboard mode not triggering a reload

Browse Source
This commit is contained in:
Dean Herbert 2021-06-07 17:32:04 +09:00
parent f677f9b5f4
commit 59130be99c
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
osu.Game/Screens/Backgrounds/BackgroundScreenDefault.cs
View File

@ -108,15 +108,16 @@ namespace osu.Game.Screens.Backgrounds
case BackgroundSource.Beatmap: case BackgroundSource.Beatmap:
case BackgroundSource.BeatmapWithStoryboard: case BackgroundSource.BeatmapWithStoryboard:
{ {
// this method is called in many cases where the beatmap hasn't changed (ie. on screen transitions).
// if a background is already displayed for the requested beatmap, we don't want to load it again.
if ((background as BeatmapBackground)?.Beatmap == beatmap.Value)
return background;
if (mode.Value == BackgroundSource.BeatmapWithStoryboard && AllowStoryboardBackground) if (mode.Value == BackgroundSource.BeatmapWithStoryboard && AllowStoryboardBackground)
newBackground = new BeatmapBackgroundWithStoryboard(beatmap.Value, getBackgroundTextureName()); newBackground = new BeatmapBackgroundWithStoryboard(beatmap.Value, getBackgroundTextureName());
newBackground ??= new BeatmapBackground(beatmap.Value, getBackgroundTextureName()); newBackground ??= new BeatmapBackground(beatmap.Value, getBackgroundTextureName());
// this method is called in many cases where the beatmap hasn't changed (ie. on screen transitions).
// if a background is already displayed for the requested beatmap, we don't want to load it again.
if (background?.GetType() == newBackground.GetType() &&
(background as BeatmapBackground)?.Beatmap == beatmap.Value)
return background;
break; break;
} }
} }