From 57f793aff0e6f562198b732dea85f9bd8c154dee Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Mon, 31 Jan 2022 15:12:08 +0900
Subject: [PATCH] Rename dictionary and make `private` for added safety

---
 osu.Game.Tests/Visual/Gameplay/TestSceneSpectator.cs   | 2 +-
 osu.Game/Tests/Visual/Spectator/TestSpectatorClient.cs | 7 +++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/osu.Game.Tests/Visual/Gameplay/TestSceneSpectator.cs b/osu.Game.Tests/Visual/Gameplay/TestSceneSpectator.cs
index d1a25b07ec..917b3c89a8 100644
--- a/osu.Game.Tests/Visual/Gameplay/TestSceneSpectator.cs
+++ b/osu.Game.Tests/Visual/Gameplay/TestSceneSpectator.cs
@@ -215,7 +215,7 @@ namespace osu.Game.Tests.Visual.Gameplay
             });
 
             // We can't access API because we're an "online" test.
-            AddAssert("last received frame has time = 1000", () => spectatorClient.LastReceivedFrame.First().Value.Time == 1000);
+            AddAssert("last received frame has time = 1000", () => spectatorClient.LastReceivedUserFrames.First().Value.Time == 1000);
         }
 
         private OsuFramedReplayInputHandler replayHandler =>
diff --git a/osu.Game/Tests/Visual/Spectator/TestSpectatorClient.cs b/osu.Game/Tests/Visual/Spectator/TestSpectatorClient.cs
index 3f3d0f5b01..1a1d493249 100644
--- a/osu.Game/Tests/Visual/Spectator/TestSpectatorClient.cs
+++ b/osu.Game/Tests/Visual/Spectator/TestSpectatorClient.cs
@@ -28,7 +28,10 @@ namespace osu.Game.Tests.Visual.Spectator
 
         public override IBindable<bool> IsConnected { get; } = new Bindable<bool>(true);
 
-        public readonly Dictionary<int, ReplayFrame> LastReceivedFrame = new Dictionary<int, ReplayFrame>();
+        public IReadOnlyDictionary<int, ReplayFrame> LastReceivedUserFrames => lastReceivedUserFrames;
+
+        private readonly Dictionary<int, ReplayFrame> lastReceivedUserFrames = new Dictionary<int, ReplayFrame>();
+
         private readonly Dictionary<int, int> userBeatmapDictionary = new Dictionary<int, int>();
         private readonly Dictionary<int, int> userNextFrameDictionary = new Dictionary<int, int>();
 
@@ -40,7 +43,7 @@ namespace osu.Game.Tests.Visual.Spectator
             OnNewFrames += (i, bundle) =>
             {
                 if (PlayingUsers.Contains(i))
-                    LastReceivedFrame[i] = bundle.Frames[^1];
+                    lastReceivedUserFrames[i] = bundle.Frames[^1];
             };
         }