From 576be6793bc7aac3fcc9d42ff1b71fdf84276a9c Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Fri, 9 Jan 2026 16:52:04 +0900 Subject: [PATCH] Add proper logging of failed scenario in `OnlineLookupCache` --- osu.Game/Database/OnlineLookupCache.cs | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/osu.Game/Database/OnlineLookupCache.cs b/osu.Game/Database/OnlineLookupCache.cs index cedb406048..a8bd5cbff2 100644 --- a/osu.Game/Database/OnlineLookupCache.cs +++ b/osu.Game/Database/OnlineLookupCache.cs @@ -8,6 +8,8 @@ using System.Threading; using System.Threading.Tasks; using osu.Framework.Allocation; using osu.Framework.Extensions; +using osu.Framework.Extensions.ExceptionExtensions; +using osu.Framework.Logging; using osu.Game.Online.API; namespace osu.Game.Database @@ -163,6 +165,14 @@ namespace osu.Game.Database } } - private void createNewTask() => pendingRequestTask = Task.Run(performLookup); + private void createNewTask() + { + var nextTask = Task.Run(performLookup); + nextTask.ContinueWith(t => + { + Logger.Error(t.Exception.AsSingular(), $"{nameof(OnlineLookupCache)} lookup request failed!"); + }, TaskContinuationOptions.OnlyOnFaulted); + pendingRequestTask = nextTask; + } } }