From 53d542546e1ae25edbf4afe3e777eee2b5038a92 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Tue, 23 Jun 2020 18:04:50 +0900
Subject: [PATCH] Fix editor drag selection not continuing to select unless the
 mouse is moved

---
 .../Edit/Compose/Components/DragBox.cs        | 25 ++++++++++++++-----
 1 file changed, 19 insertions(+), 6 deletions(-)

diff --git a/osu.Game/Screens/Edit/Compose/Components/DragBox.cs b/osu.Game/Screens/Edit/Compose/Components/DragBox.cs
index c5f1bd1575..0615ebfc20 100644
--- a/osu.Game/Screens/Edit/Compose/Components/DragBox.cs
+++ b/osu.Game/Screens/Edit/Compose/Components/DragBox.cs
@@ -53,6 +53,8 @@ namespace osu.Game.Screens.Edit.Compose.Components
             }
         };
 
+        private RectangleF? dragRectangle;
+
         /// <summary>
         /// Handle a forwarded mouse event.
         /// </summary>
@@ -66,15 +68,14 @@ namespace osu.Game.Screens.Edit.Compose.Components
             var dragQuad = new Quad(dragStartPosition.X, dragStartPosition.Y, dragPosition.X - dragStartPosition.X, dragPosition.Y - dragStartPosition.Y);
 
             // We use AABBFloat instead of RectangleF since it handles negative sizes for us
-            var dragRectangle = dragQuad.AABBFloat;
+            var rec = dragQuad.AABBFloat;
+            dragRectangle = rec;
 
-            var topLeft = ToLocalSpace(dragRectangle.TopLeft);
-            var bottomRight = ToLocalSpace(dragRectangle.BottomRight);
+            var topLeft = ToLocalSpace(rec.TopLeft);
+            var bottomRight = ToLocalSpace(rec.BottomRight);
 
             Box.Position = topLeft;
             Box.Size = bottomRight - topLeft;
-
-            PerformSelection?.Invoke(dragRectangle);
             return true;
         }
 
@@ -93,7 +94,19 @@ namespace osu.Game.Screens.Edit.Compose.Components
             }
         }
 
-        public override void Hide() => State = Visibility.Hidden;
+        protected override void Update()
+        {
+            base.Update();
+
+            if (dragRectangle != null)
+                PerformSelection?.Invoke(dragRectangle.Value);
+        }
+
+        public override void Hide()
+        {
+            State = Visibility.Hidden;
+            dragRectangle = null;
+        }
 
         public override void Show() => State = Visibility.Visible;