From 53bca947d13fe267260e3767c67cd6e30efd2154 Mon Sep 17 00:00:00 2001
From: BlauFx <clanpower15@gmail.com>
Date: Wed, 28 Dec 2022 14:34:27 +0100
Subject: [PATCH] Move duplicated code into its own method

---
 osu.Game/Database/RealmFileStore.cs | 15 ++-------------
 osu.Game/IO/HardLinkHelper.cs       | 23 ++++++++++++++---------
 2 files changed, 16 insertions(+), 22 deletions(-)

diff --git a/osu.Game/Database/RealmFileStore.cs b/osu.Game/Database/RealmFileStore.cs
index 49102d81e5..e5ace5b346 100644
--- a/osu.Game/Database/RealmFileStore.cs
+++ b/osu.Game/Database/RealmFileStore.cs
@@ -64,19 +64,8 @@ namespace osu.Game.Database
         private void copyToStore(RealmFile file, Stream data, bool preferHardLinks)
         {
             // attempt to do a fast hard link rather than copy.
-            if (data is FileStream fs && preferHardLinks)
-            {
-                if (RuntimeInfo.OS == RuntimeInfo.Platform.Windows)
-                {
-                    if (HardLinkHelper.CreateHardLink(Storage.GetFullPath(file.GetStoragePath(), true), fs.Name, IntPtr.Zero))
-                        return;
-                }
-                else if (RuntimeInfo.OS == RuntimeInfo.Platform.Linux)
-                {
-                    if (HardLinkHelper.link(fs.Name, Storage.GetFullPath(file.GetStoragePath(), true)) == 0)
-                        return;
-                }
-            }
+            if (data is FileStream fs && preferHardLinks && HardLinkHelper.AttemptHardLink(Storage.GetFullPath(file.GetStoragePath(), true), fs.Name))
+                return;
 
             data.Seek(0, SeekOrigin.Begin);
 
diff --git a/osu.Game/IO/HardLinkHelper.cs b/osu.Game/IO/HardLinkHelper.cs
index d059e8b710..c8fc6d9f49 100644
--- a/osu.Game/IO/HardLinkHelper.cs
+++ b/osu.Game/IO/HardLinkHelper.cs
@@ -28,16 +28,9 @@ namespace osu.Game.IO
             try
             {
                 File.WriteAllText(testSourcePath, string.Empty);
+
                 // Test availability by creating an arbitrary hard link between the source and destination paths.
-
-                bool isHardLinkAvailable = false;
-
-                if (RuntimeInfo.OS == RuntimeInfo.Platform.Windows)
-                    isHardLinkAvailable = CreateHardLink(testDestinationPath, testSourcePath, IntPtr.Zero);
-                else if (RuntimeInfo.OS == RuntimeInfo.Platform.Linux)
-                    isHardLinkAvailable = link(testSourcePath, testDestinationPath) == 0;
-
-                return isHardLinkAvailable;
+                return AttemptHardLink(testDestinationPath, testSourcePath);
             }
             catch
             {
@@ -61,6 +54,18 @@ namespace osu.Game.IO
             }
         }
 
+        public static bool AttemptHardLink(string testDestinationPath, string testSourcePath)
+        {
+            bool isHardLinkAvailable = false;
+
+            if (RuntimeInfo.OS == RuntimeInfo.Platform.Windows)
+                isHardLinkAvailable = CreateHardLink(testDestinationPath, testSourcePath, IntPtr.Zero);
+            else if (RuntimeInfo.OS == RuntimeInfo.Platform.Linux)
+                isHardLinkAvailable = link(testSourcePath, testDestinationPath) == 0;
+
+            return isHardLinkAvailable;
+        }
+
         // For future use (to detect if a file is a hard link with other references existing on disk).
         public static int GetFileLinkCount(string filePath)
         {