mirror of
https://github.com/ppy/osu.git
synced 2025-01-26 18:03:11 +08:00
Remove ScaleFixContainer.
This commit is contained in:
parent
d72a479d9d
commit
5352da277d
@ -55,12 +55,6 @@ namespace osu.Game.Rulesets.Taiko.UI
|
||||
public TaikoPlayfield()
|
||||
{
|
||||
AddRangeInternal(new Drawable[]
|
||||
{
|
||||
new ScaleFixContainer
|
||||
{
|
||||
RelativeSizeAxes = Axes.X,
|
||||
Height = DEFAULT_PLAYFIELD_HEIGHT,
|
||||
Children = new[]
|
||||
{
|
||||
backgroundContainer = new Container
|
||||
{
|
||||
@ -137,7 +131,8 @@ namespace osu.Game.Rulesets.Taiko.UI
|
||||
overlayBackgroundContainer = new Container
|
||||
{
|
||||
Name = "Left overlay",
|
||||
Size = new Vector2(left_area_size, DEFAULT_PLAYFIELD_HEIGHT),
|
||||
RelativeSizeAxes = Axes.Y,
|
||||
Size = new Vector2(left_area_size, 1),
|
||||
BorderThickness = 1,
|
||||
Children = new Drawable[]
|
||||
{
|
||||
@ -162,8 +157,6 @@ namespace osu.Game.Rulesets.Taiko.UI
|
||||
},
|
||||
}
|
||||
},
|
||||
}
|
||||
},
|
||||
topLevelHitContainer = new Container
|
||||
{
|
||||
Name = "Top level hit objects",
|
||||
@ -233,56 +226,5 @@ namespace osu.Game.Rulesets.Taiko.UI
|
||||
else
|
||||
hitExplosionContainer.Children.FirstOrDefault(e => e.Judgement == judgedObject.Judgement)?.VisualiseSecondHit();
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// This is a very special type of container. It serves a similar purpose to <see cref="FillMode.Fit"/>, however unlike <see cref="FillMode.Fit"/>,
|
||||
/// this will only adjust the scale relative to the height of its parent and will maintain the original width relative to its parent.
|
||||
///
|
||||
/// <para>
|
||||
/// By adjusting the scale relative to the height of its parent, the aspect ratio of this container's children is maintained, however this is undesirable
|
||||
/// in the case where the hit object container should not have its width adjusted by scale. To counteract this, another container is nested inside this
|
||||
/// container which takes care of reversing the width adjustment while appearing transparent to the user.
|
||||
/// </para>
|
||||
/// </summary>
|
||||
private class ScaleFixContainer : Container
|
||||
{
|
||||
protected override Container<Drawable> Content => widthAdjustmentContainer;
|
||||
private readonly WidthAdjustmentContainer widthAdjustmentContainer;
|
||||
|
||||
/// <summary>
|
||||
/// We only want to apply DrawScale in the Y-axis to preserve aspect ratio and <see cref="TaikoPlayfield"/> doesn't care about having its width adjusted.
|
||||
/// </summary>
|
||||
protected override Vector2 DrawScale => Scale * RelativeToAbsoluteFactor.Y / DrawHeight;
|
||||
|
||||
public ScaleFixContainer()
|
||||
{
|
||||
AddInternal(widthAdjustmentContainer = new WidthAdjustmentContainer { ParentDrawScaleReference = () => DrawScale.X });
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// The container type that reverses the <see cref="Drawable.DrawScale"/> width adjustment.
|
||||
/// </summary>
|
||||
private class WidthAdjustmentContainer : Container
|
||||
{
|
||||
/// <summary>
|
||||
/// This container needs to know its parent's <see cref="Drawable.DrawScale"/> so it can reverse the width adjustment caused by <see cref="Drawable.DrawScale"/>.
|
||||
/// </summary>
|
||||
public Func<float> ParentDrawScaleReference;
|
||||
|
||||
public WidthAdjustmentContainer()
|
||||
{
|
||||
// This container doesn't care about height, it should always fill its parent
|
||||
RelativeSizeAxes = Axes.Y;
|
||||
}
|
||||
|
||||
protected override void Update()
|
||||
{
|
||||
base.Update();
|
||||
|
||||
// Reverse the DrawScale adjustment
|
||||
Width = Parent.DrawSize.X / ParentDrawScaleReference();
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
Loading…
Reference in New Issue
Block a user