mirror of
https://github.com/ppy/osu.git
synced 2025-01-13 19:04:06 +08:00
Improve ScoresContainer
loading overlay logic to work better with tests
This commit is contained in:
parent
e83c83a5e8
commit
51ade3251d
@ -65,6 +65,9 @@ namespace osu.Game.Overlays.BeatmapSet.Scores
|
|||||||
scoreTable.ClearScores();
|
scoreTable.ClearScores();
|
||||||
scoreTable.Hide();
|
scoreTable.Hide();
|
||||||
|
|
||||||
|
loading.Hide();
|
||||||
|
loading.FinishTransforms();
|
||||||
|
|
||||||
if (value?.Scores.Any() != true)
|
if (value?.Scores.Any() != true)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
@ -258,9 +261,6 @@ namespace osu.Game.Overlays.BeatmapSet.Scores
|
|||||||
{
|
{
|
||||||
Scores = null;
|
Scores = null;
|
||||||
notSupporterPlaceholder.Show();
|
notSupporterPlaceholder.Show();
|
||||||
|
|
||||||
loading.Hide();
|
|
||||||
loading.FinishTransforms();
|
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -272,9 +272,6 @@ namespace osu.Game.Overlays.BeatmapSet.Scores
|
|||||||
getScoresRequest = new GetScoresRequest(Beatmap.Value, Beatmap.Value.Ruleset, scope.Value, modSelector.SelectedMods);
|
getScoresRequest = new GetScoresRequest(Beatmap.Value, Beatmap.Value.Ruleset, scope.Value, modSelector.SelectedMods);
|
||||||
getScoresRequest.Success += scores =>
|
getScoresRequest.Success += scores =>
|
||||||
{
|
{
|
||||||
loading.Hide();
|
|
||||||
loading.FinishTransforms();
|
|
||||||
|
|
||||||
Scores = scores;
|
Scores = scores;
|
||||||
|
|
||||||
if (!scores.Scores.Any())
|
if (!scores.Scores.Any())
|
||||||
|
Loading…
Reference in New Issue
Block a user