From 4fcdfa2cfc5cc92ba0f0f23e7e8700a9f56ee025 Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Tue, 3 Jun 2025 22:48:21 +0900 Subject: [PATCH] Move state updates to separate method and flow --- osu.Game/Screens/SelectV2/SongSelect.cs | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/osu.Game/Screens/SelectV2/SongSelect.cs b/osu.Game/Screens/SelectV2/SongSelect.cs index 8c362c2b44..d77764d916 100644 --- a/osu.Game/Screens/SelectV2/SongSelect.cs +++ b/osu.Game/Screens/SelectV2/SongSelect.cs @@ -303,7 +303,17 @@ namespace osu.Game.Screens.SelectV2 .FadeTo(v.NewValue == Visibility.Visible ? 0f : 1f, 200, Easing.OutQuint); }); - Beatmap.BindValueChanged(_ => ensureGlobalBeatmapValid()); + Beatmap.BindValueChanged(_ => + { + ensureGlobalBeatmapValid(); + updateStateFromCurrentBeatmap(); + }); + } + + private void updateStateFromCurrentBeatmap() + { + ensurePlayingSelected(); + updateBackgroundDim(); } protected override void Update() @@ -467,9 +477,6 @@ namespace osu.Game.Screens.SelectV2 else Beatmap.SetDefault(); - ensurePlayingSelected(); - updateBackgroundDim(); - return validSelection; } @@ -548,6 +555,8 @@ namespace osu.Game.Screens.SelectV2 attachTrackDuckingIfShould(); ensureGlobalBeatmapValid(); + + updateStateFromCurrentBeatmap(); } private void onLeavingScreen()