From e505e71d07ae4109ad66de2e6fee801bd217cc16 Mon Sep 17 00:00:00 2001 From: Susko3 Date: Fri, 30 Jun 2023 21:40:00 +0200 Subject: [PATCH 1/5] Merge the two `app.manifest` files --- app.manifest | 1 + osu.Desktop/app.manifest | 21 --------------------- osu.Desktop/osu.Desktop.csproj | 1 - 3 files changed, 1 insertion(+), 22 deletions(-) delete mode 100644 osu.Desktop/app.manifest diff --git a/app.manifest b/app.manifest index 533c6ff208..b85df82c4d 100644 --- a/app.manifest +++ b/app.manifest @@ -1,6 +1,7 @@  + 1 diff --git a/osu.Desktop/app.manifest b/osu.Desktop/app.manifest deleted file mode 100644 index a11cee132c..0000000000 --- a/osu.Desktop/app.manifest +++ /dev/null @@ -1,21 +0,0 @@ - - - - 1 - - - - - - - - - - - - - - true - - - diff --git a/osu.Desktop/osu.Desktop.csproj b/osu.Desktop/osu.Desktop.csproj index f1b9c92429..16d6a81d40 100644 --- a/osu.Desktop/osu.Desktop.csproj +++ b/osu.Desktop/osu.Desktop.csproj @@ -8,7 +8,6 @@ osu! osu!(lazer) lazer.ico - app.manifest 0.0.0 0.0.0 From 909edefa2048f59ffb6cf623f8fce8d16f5ca2d2 Mon Sep 17 00:00:00 2001 From: Susko3 Date: Fri, 30 Jun 2023 21:41:18 +0200 Subject: [PATCH 2/5] Remove unnecessary `` osu! was working fine without this. --- app.manifest | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/app.manifest b/app.manifest index b85df82c4d..2e5ba1b18a 100644 --- a/app.manifest +++ b/app.manifest @@ -32,16 +32,4 @@ true - - - - - From bfa5bcb2a77de4b3416128b8d829e99fee06036d Mon Sep 17 00:00:00 2001 From: Susko3 Date: Fri, 30 Jun 2023 21:43:01 +0200 Subject: [PATCH 3/5] Update `` to match what osu! actually supports --- app.manifest | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/app.manifest b/app.manifest index 2e5ba1b18a..69702111ce 100644 --- a/app.manifest +++ b/app.manifest @@ -15,15 +15,9 @@ - - - - - - - + From b0e716feab3f728e4bf59b3800a86fdaf1e030ee Mon Sep 17 00:00:00 2001 From: Susko3 Date: Fri, 30 Jun 2023 21:59:46 +0200 Subject: [PATCH 4/5] Use correct `perMonitorV2` `` Yes, `xmlns="http://schemas.microsoft.com/SMI/2016/WindowsSettings"` is required else the game will exit with code 500 on startup. --- app.manifest | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app.manifest b/app.manifest index 69702111ce..ad8b5d005a 100644 --- a/app.manifest +++ b/app.manifest @@ -23,7 +23,8 @@ - true + per Monitor + perMonitorV2 From caba571263b6fca21fde60d25ac755a8308e21ec Mon Sep 17 00:00:00 2001 From: Susko3 Date: Sat, 1 Jul 2023 19:11:48 +0200 Subject: [PATCH 5/5] Remove manifest DPI awareness entires It'll be properly handled by osu!framework with https://github.com/ppy/osu/pull/24092 --- app.manifest | 6 ------ 1 file changed, 6 deletions(-) diff --git a/app.manifest b/app.manifest index ad8b5d005a..088ad1dde7 100644 --- a/app.manifest +++ b/app.manifest @@ -21,10 +21,4 @@ - - - per Monitor - perMonitorV2 - -