h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-15 23:23:04 +08:00
Code Issues Releases Wiki Activity

WIP refresh BPM-Label on mod change

Browse Source
This commit is contained in:
Denrage 2021-04-20 12:00:04 +02:00
parent 6e72ee5f76
commit 4e6cd8082e
1 changed files with 17 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
osu.Game/Screens/Select/BeatmapInfoWedge.cs
View File

@ -150,7 +150,7 @@ namespace osu.Game.Screens.Select
removeOldInfo(); removeOldInfo();
Add(Background = loaded); Add(Background = loaded);
Add(Info = new WedgeInfoText(beatmap, ruleset.Value, mods.Value, beatmapDifficulty) Add(Info = new WedgeInfoText(beatmap, ruleset.Value, mods, beatmapDifficulty)
{ {
Shear = -Shear Shear = -Shear
}); });
@ -181,10 +181,10 @@ namespace osu.Game.Screens.Select
private readonly WorkingBeatmap beatmap; private readonly WorkingBeatmap beatmap;
private readonly RulesetInfo ruleset; private readonly RulesetInfo ruleset;
private readonly IReadOnlyList<Mod> mods; private readonly IBindable<IReadOnlyList<Mod>> mods;
private readonly IBindable<StarDifficulty?> starDifficulty; private readonly IBindable<StarDifficulty?> starDifficulty;
public WedgeInfoText(WorkingBeatmap beatmap, RulesetInfo userRuleset, IReadOnlyList<Mod> mods, IBindable<StarDifficulty?> difficulty) public WedgeInfoText(WorkingBeatmap beatmap, RulesetInfo userRuleset, IBindable<IReadOnlyList<Mod>> mods, IBindable<StarDifficulty?> difficulty)
{ {
this.beatmap = beatmap; this.beatmap = beatmap;
ruleset = userRuleset ?? beatmap.BeatmapInfo.Ruleset; ruleset = userRuleset ?? beatmap.BeatmapInfo.Ruleset;
@ -300,14 +300,16 @@ namespace osu.Game.Screens.Select
} }
}; };
addInfoLabels();
titleBinding.BindValueChanged(_ => setMetadata(metadata.Source)); titleBinding.BindValueChanged(_ => setMetadata(metadata.Source));
artistBinding.BindValueChanged(_ => setMetadata(metadata.Source), true); artistBinding.BindValueChanged(_ => setMetadata(metadata.Source), true);
starDifficulty.BindValueChanged(_ => setStarRatingDisplayVisibility(), true);
// no difficulty means it can't have a status to show // no difficulty means it can't have a status to show
if (beatmapInfo.Version == null) if (beatmapInfo.Version == null)
StatusPill.Hide(); StatusPill.Hide();
addInfoLabels();
} }
private void setStarRatingDisplayVisibility() private void setStarRatingDisplayVisibility()
@ -349,7 +351,7 @@ namespace osu.Game.Screens.Select
return Array.Empty<InfoLabel>(); return Array.Empty<InfoLabel>();
} }
private void refreshBPMLabel() private void refreshBPMLabel(IReadOnlyList<Mod> mods)
{ {
var b = beatmap.Beatmap; var b = beatmap.Beatmap;
if (b == null) if (b == null)
@ -407,10 +409,16 @@ namespace osu.Game.Screens.Select
} }
}; };
settingChangeTracker = new ModSettingChangeTracker(mods); // this is currently not triggering when a mod gets (de)selected
settingChangeTracker.SettingChanged += _ => refreshBPMLabel(); mods.BindValueChanged(mods => refreshModInformation(mods), true);
}
refreshBPMLabel(); private void refreshModInformation(ValueChangedEvent<IReadOnlyList<Mod>> modsChangedEvent)
{
settingChangeTracker?.Dispose();
settingChangeTracker = new ModSettingChangeTracker(modsChangedEvent.NewValue);
settingChangeTracker.SettingChanged += _ => refreshBPMLabel(modsChangedEvent.NewValue);
refreshBPMLabel(mods.Value);
} }
private OsuSpriteText[] getMapper(BeatmapMetadata metadata) private OsuSpriteText[] getMapper(BeatmapMetadata metadata)
@ -467,8 +475,7 @@ namespace osu.Game.Screens.Select
} }
}; };
difficulty.BindValueChanged(_ => setColour(colours)); difficulty.BindValueChanged(_ => setColour(colours), true);
setColour(colours);
} }
private void setColour(OsuColour colours) private void setColour(OsuColour colours)