From 4ddf05602f1f117f8ab0248c937a2487e76f59a3 Mon Sep 17 00:00:00 2001
From: Joseph Madamba <madamba.joehu@outlook.com>
Date: Sat, 29 Jul 2023 11:05:15 -0700
Subject: [PATCH] Update `BreakInfoLine` to formatting standards

---
 osu.Game/Screens/Play/Break/BreakInfoLine.cs | 34 ++++++++++++--------
 1 file changed, 21 insertions(+), 13 deletions(-)

diff --git a/osu.Game/Screens/Play/Break/BreakInfoLine.cs b/osu.Game/Screens/Play/Break/BreakInfoLine.cs
index 3357963fac..147650ca07 100644
--- a/osu.Game/Screens/Play/Break/BreakInfoLine.cs
+++ b/osu.Game/Screens/Play/Break/BreakInfoLine.cs
@@ -21,21 +21,30 @@ namespace osu.Game.Screens.Play.Break
 
         public Bindable<T> Current = new Bindable<T>();
 
-        private readonly OsuSpriteText text;
-        private readonly OsuSpriteText valueText;
+        private readonly LocalisableString name;
+
+        private OsuSpriteText valueText = null!;
 
         public BreakInfoLine(LocalisableString name)
         {
+            this.name = name;
+
             AutoSizeAxes = Axes.Y;
+        }
+
+        [BackgroundDependencyLoader]
+        private void load(OsuColour colours)
+        {
             Children = new Drawable[]
             {
-                text = new OsuSpriteText
+                new OsuSpriteText
                 {
                     Anchor = Anchor.Centre,
                     Origin = Anchor.CentreRight,
                     Text = name,
                     Font = OsuFont.GetFont(size: 17),
-                    Margin = new MarginPadding { Right = margin }
+                    Margin = new MarginPadding { Right = margin },
+                    Colour = colours.Yellow,
                 },
                 valueText = new OsuSpriteText
                 {
@@ -43,11 +52,17 @@ namespace osu.Game.Screens.Play.Break
                     Origin = Anchor.CentreLeft,
                     Text = @"-",
                     Font = OsuFont.GetFont(weight: FontWeight.Bold, size: 17),
-                    Margin = new MarginPadding { Left = margin }
+                    Margin = new MarginPadding { Left = margin },
+                    Colour = colours.YellowLight,
                 }
             };
+        }
 
-            Current.ValueChanged += text => valueText.Text = Format(text.NewValue);
+        protected override void LoadComplete()
+        {
+            base.LoadComplete();
+
+            Current.BindValueChanged(text => valueText.Text = Format(text.NewValue), true);
         }
 
         protected virtual LocalisableString Format(T count)
@@ -57,13 +72,6 @@ namespace osu.Game.Screens.Play.Break
 
             return count.ToString() ?? string.Empty;
         }
-
-        [BackgroundDependencyLoader]
-        private void load(OsuColour colours)
-        {
-            text.Colour = colours.Yellow;
-            valueText.Colour = colours.YellowLight;
-        }
     }
 
     public partial class PercentageBreakInfoLine : BreakInfoLine<double>