h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-06 06:13:04 +08:00
Code Issues Releases Wiki Activity

Further simplify non-transactional change logic

Browse Source
This commit is contained in:
Dean Herbert 2020-10-08 18:42:53 +09:00
parent 3114174e09
commit 4ccd751604
1 changed files with 6 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
osu.Game/Screens/Edit/EditorBeatmap.cs
View File

@ -131,18 +131,9 @@ namespace osu.Game.Screens.Edit
mutableHitObjects.Insert(index, hitObject); mutableHitObjects.Insert(index, hitObject);
if (TransactionActive) BeginChange();
batchPendingInserts.Add(hitObject); batchPendingInserts.Add(hitObject);
else EndChange();
{
// must be run after any change to hitobject ordering
beatmapProcessor?.PreProcess();
processHitObject(hitObject);
beatmapProcessor?.PostProcess();
HitObjectAdded?.Invoke(hitObject);
SaveState();
}
} }
/// <summary> /// <summary>
@ -213,18 +204,9 @@ namespace osu.Game.Screens.Edit
bindable.UnbindAll(); bindable.UnbindAll();
startTimeBindables.Remove(hitObject); startTimeBindables.Remove(hitObject);
if (TransactionActive) BeginChange();
batchPendingDeletes.Add(hitObject); batchPendingDeletes.Add(hitObject);
else EndChange();
{
// must be run after any change to hitobject ordering
beatmapProcessor?.PreProcess();
processHitObject(hitObject);
beatmapProcessor?.PostProcess();
HitObjectRemoved?.Invoke(hitObject);
SaveState();
}
} }
protected override void Update() protected override void Update()