h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-08 06:52:59 +08:00
Code Issues Releases Wiki Activity

Merge pull request #27077 from peppy/log-fire-and-forget-better

Browse Source 
Improve exception logging of unobserved exceptions via `FireAndForget`
This commit is contained in:
Bartłomiej Dach 2024-02-10 13:43:50 +01:00 committed by GitHub
commit 4a516cbccd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game/Online/Multiplayer/MultiplayerClientExtensions.cs
View File

@ -23,9 +23,12 @@ namespace osu.Game.Online.Multiplayer
Debug.Assert(exception != null); Debug.Assert(exception != null);
string message = exception.GetHubExceptionMessage() ?? exception.Message; if (exception.GetHubExceptionMessage() is string message)
// Hub exceptions generally contain something we can show the user directly.
Logger.Log(message, level: LogLevel.Important);
else
Logger.Error(exception, $"Unobserved exception occurred via {nameof(FireAndForget)} call: {exception.Message}");
Logger.Log(message, level: LogLevel.Important);
onError?.Invoke(exception); onError?.Invoke(exception);
} }
else else