1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-12 21:02:54 +08:00

Split out star constant to reuse in pool definition

This commit is contained in:
Dean Herbert 2023-07-18 16:14:54 +09:00
parent e6e66c6aef
commit 49bb0b190a

View File

@ -13,6 +13,8 @@ namespace osu.Game.Screens.Menu
{ {
public partial class StarFountain : CompositeDrawable public partial class StarFountain : CompositeDrawable
{ {
private const int stars_per_shoot = 192;
private DrawablePool<Star> starPool = null!; private DrawablePool<Star> starPool = null!;
private Container starContainer = null!; private Container starContainer = null!;
@ -21,7 +23,7 @@ namespace osu.Game.Screens.Menu
{ {
InternalChildren = new Drawable[] InternalChildren = new Drawable[]
{ {
starPool = new DrawablePool<Star>(192), starPool = new DrawablePool<Star>(stars_per_shoot),
starContainer = new Container() starContainer = new Container()
}; };
} }
@ -31,8 +33,6 @@ namespace osu.Game.Screens.Menu
// left centre or right movement. // left centre or right movement.
int direction = RNG.Next(-1, 2); int direction = RNG.Next(-1, 2);
const int total_stars = 192;
const float x_velocity_from_direction = 0.6f; const float x_velocity_from_direction = 0.6f;
const float x_velocity_random_variance = 0.25f; const float x_velocity_random_variance = 0.25f;
@ -42,7 +42,7 @@ namespace osu.Game.Screens.Menu
const float x_spawn_position_variance = 10; const float x_spawn_position_variance = 10;
const float y_spawn_position_offset = 50; const float y_spawn_position_offset = 50;
for (int i = 0; i < total_stars; i++) for (int i = 0; i < stars_per_shoot; i++)
{ {
double initialOffset = i * 3; double initialOffset = i * 3;