h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-13 10:03:05 +08:00
Code Issues Releases Wiki Activity

Avoid needlessly updating display (and add better documentation on chosen scale)

Browse Source
This commit is contained in:
Dean Herbert 2022-05-24 14:33:05 +09:00
parent 4fcdcef166
commit 49a2173646
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
osu.Game/Screens/Edit/Timing/WaveformComparisonDisplay.cs
View File

@ -136,14 +136,21 @@ namespace osu.Game.Screens.Edit.Timing
if (!IsHovered) if (!IsHovered)
{ {
int beatOffset = (int)Math.Floor((editorClock.CurrentTimeAccurate - selectedGroupStartTime) / timingPoint.BeatLength); int currentBeat = (int)Math.Floor((editorClock.CurrentTimeAccurate - selectedGroupStartTime) / timingPoint.BeatLength);
showFrom(beatOffset); showFrom(currentBeat);
} }
} }
private void showFrom(int beatIndex) private void showFrom(int beatIndex)
{ {
if (lastDisplayedBeatIndex == beatIndex)
return;
// Chosen as a pretty usable number across all BPMs.
// Optimally we'd want this to scale with the BPM in question, but performing
// scaling of the display is both expensive in resampling, and decreases usability
// (as it is harder to track the waveform when making realtime adjustments).
const float visible_width = 300; const float visible_width = 300;
float trackLength = (float)beatmap.Value.Track.Length; float trackLength = (float)beatmap.Value.Track.Length;