h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-15 23:42:55 +08:00
Code Issues Releases Wiki Activity

Merge pull request #25301 from peppy/inspections-bash

Browse Source 
Fix some new nullable inspections
This commit is contained in:
Bartłomiej Dach 2023-10-30 08:42:34 +01:00 committed by GitHub
commit 46d1eca0c7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
osu.Game.Rulesets.Osu/Objects/Slider.cs
View File

@ -49,13 +49,9 @@ namespace osu.Game.Rulesets.Osu.Objects
set set
{ {
path.ControlPoints.Clear(); path.ControlPoints.Clear();
path.ExpectedDistance.Value = null; path.ControlPoints.AddRange(value.ControlPoints.Select(c => new PathControlPoint(c.Position, c.Type)));
if (value != null) path.ExpectedDistance.Value = value.ExpectedDistance.Value;
{
path.ControlPoints.AddRange(value.ControlPoints.Select(c => new PathControlPoint(c.Position, c.Type)));
path.ExpectedDistance.Value = value.ExpectedDistance.Value;
}
} }
} }

2
osu.Game/Rulesets/Edit/SelectionBlueprint.cs
View File

@ -5,6 +5,7 @@
using System; using System;
using System.Linq; using System.Linq;
using JetBrains.Annotations;
using osu.Framework; using osu.Framework;
using osu.Framework.Graphics; using osu.Framework.Graphics;
using osu.Framework.Graphics.Containers; using osu.Framework.Graphics.Containers;
@ -51,6 +52,7 @@ namespace osu.Game.Rulesets.Edit
private SelectionState state; private SelectionState state;
[CanBeNull]
public event Action<SelectionState> StateChanged; public event Action<SelectionState> StateChanged;
public SelectionState State public SelectionState State

2
osu.Game/Screens/Backgrounds/BackgroundScreenBeatmap.cs
View File

@ -166,6 +166,8 @@ namespace osu.Game.Screens.Backgrounds
public override void Add(Drawable drawable) public override void Add(Drawable drawable)
{ {
ArgumentNullException.ThrowIfNull(drawable);
if (drawable is Background) if (drawable is Background)
throw new InvalidOperationException($"Use {nameof(Background)} to set a background."); throw new InvalidOperationException($"Use {nameof(Background)} to set a background.");

2
osu.Game/Screens/Play/SquareGraph.cs
View File

@ -7,6 +7,7 @@ using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq; using System.Linq;
using System.Threading; using System.Threading;
using JetBrains.Annotations;
using osu.Framework; using osu.Framework;
using osu.Framework.Extensions.Color4Extensions; using osu.Framework.Extensions.Color4Extensions;
using osu.Framework.Graphics; using osu.Framework.Graphics;
@ -190,6 +191,7 @@ namespace osu.Game.Screens.Play
private const float padding = 2; private const float padding = 2;
public const float WIDTH = cube_size + padding; public const float WIDTH = cube_size + padding;
[CanBeNull]
public event Action<ColumnState> StateChanged; public event Action<ColumnState> StateChanged;
private readonly List<Box> drawableRows = new List<Box>(); private readonly List<Box> drawableRows = new List<Box>();