mirror of
https://github.com/ppy/osu.git
synced 2024-12-05 10:33:22 +08:00
apply review
This commit is contained in:
parent
72210bf9fe
commit
45ed2fdec2
@ -46,13 +46,14 @@ namespace osu.Game.Rulesets.Taiko.Mods
|
|||||||
{ 3, 2 }, // 1/3 snap to 1/2 snap
|
{ 3, 2 }, // 1/3 snap to 1/2 snap
|
||||||
};
|
};
|
||||||
|
|
||||||
int patternStartIndex = 0;
|
|
||||||
bool inPattern = false;
|
bool inPattern = false;
|
||||||
|
|
||||||
List<Hit> hits = taikoBeatmap.HitObjects.Where(obj => obj is Hit).Cast<Hit>().ToList();
|
List<Hit> hits = taikoBeatmap.HitObjects.Where(obj => obj is Hit).Cast<Hit>().ToList();
|
||||||
|
|
||||||
foreach (var snapConversion in snapConversions)
|
foreach (var snapConversion in snapConversions)
|
||||||
{
|
{
|
||||||
|
int patternStartIndex = 0;
|
||||||
|
|
||||||
// Skip processing if the corresponding conversion is disabled
|
// Skip processing if the corresponding conversion is disabled
|
||||||
if (!shouldProcessRhythm(snapConversion.Key))
|
if (!shouldProcessRhythm(snapConversion.Key))
|
||||||
continue;
|
continue;
|
||||||
@ -73,8 +74,8 @@ namespace osu.Game.Rulesets.Taiko.Mods
|
|||||||
inPattern = true;
|
inPattern = true;
|
||||||
}
|
}
|
||||||
|
|
||||||
// check if end of pattern or if we're on the last note
|
// check if end of pattern
|
||||||
if ((inPattern && snapValue != snapConversion.Key) || i == hits.Count)
|
if (inPattern && snapValue != snapConversion.Key)
|
||||||
{
|
{
|
||||||
// End of the pattern
|
// End of the pattern
|
||||||
inPattern = false;
|
inPattern = false;
|
||||||
@ -109,7 +110,7 @@ namespace osu.Game.Rulesets.Taiko.Mods
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Remove queued notes
|
// Remove queued notes
|
||||||
taikoBeatmap.HitObjects = taikoBeatmap.HitObjects.Except(toRemove).ToList();
|
taikoBeatmap.HitObjects.RemoveAll(obj => toRemove.Contains(obj));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user