From 42c68ba43ee1f4a0964406425c0497d603d124cc Mon Sep 17 00:00:00 2001
From: Salman Alshamrani <frenzibyte@gmail.com>
Date: Tue, 26 Nov 2024 01:28:58 -0500
Subject: [PATCH] Add inline comment

---
 osu.Game/Online/LocalUserStatisticsProvider.cs | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/osu.Game/Online/LocalUserStatisticsProvider.cs b/osu.Game/Online/LocalUserStatisticsProvider.cs
index 312b80e18a..22d5788c87 100644
--- a/osu.Game/Online/LocalUserStatisticsProvider.cs
+++ b/osu.Game/Online/LocalUserStatisticsProvider.cs
@@ -47,10 +47,16 @@ namespace osu.Game.Online
         protected override void LoadComplete()
         {
             base.LoadComplete();
-            api.LocalUser.BindValueChanged(_ => initialiseStatistics(), true);
+
+            api.LocalUser.BindValueChanged(_ =>
+            {
+                // queuing up requests directly on user change is unsafe, as the API status may have not been updated yet.
+                // schedule a frame to allow the API to be in its correct state sending requests.
+                Schedule(initialiseStatistics);
+            }, true);
         }
 
-        private void initialiseStatistics() => Schedule(() =>
+        private void initialiseStatistics()
         {
             statisticsCache.Clear();
 
@@ -59,7 +65,7 @@ namespace osu.Game.Online
 
             foreach (var ruleset in rulesets.AvailableRulesets.Where(r => r.IsLegacyRuleset()))
                 RefetchStatistics(ruleset);
-        });
+        }
 
         public void RefetchStatistics(RulesetInfo ruleset, Action<UserStatisticsUpdate>? callback = null)
         {